-
Notifications
You must be signed in to change notification settings - Fork 19
WIP: Add Openssl with TLS 1.3 #71
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Tiger <rbalajis25@gmail.com>
Signed-off-by: Tiger <rbalajis25@gmail.com>
I'm currently working on unit tests on whichever TLS version OpenSSL chooses for me (potentially TLS 1.3, but I can't be sure). For the unit tests that don't specifically require Go's TLS implementation, 5/6 tests pass. |
This will definitely need to run on CI, once with a Go TLS build and once with an OpenSSL build. You can use a Travis build matrix for that. It would also be nice to have a kind of integration test that tests both successful and failed handshakes between one Go TLS and one OpenSSL implementation. |
How do I edit the Travis build matrix?
I have some tests setup already. I forgot to push. The collection of tests isn't finished yet for the openssl implementation. |
It's in |
@@ -24,6 +24,7 @@ script: | |||
# some tests are randomized. Run them a few times. | |||
- for i in `seq 1 10`; do | |||
ginkgo -r -v --cover --randomizeAllSpecs --randomizeSuites --trace --progress; | |||
ginkgo -tags openssl -r -v --cover --randomizeAllSpecs --randomizeSuites --trace --progress; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should use the Travis build matrix feature.
Requires: libp2p/go-openssl#13
Appends to: #67
Closes: #67
Closes: libp2p/go-libp2p#1539
This should add openssl with TLS 1.3. I'm not sure how to build with the openssl build flag (added in #67), so I haven't tested this extensively.
@marten-seemann Would you like to take a look at this?
Edit: I got the build flag to work. I'm just blocked by libp2p/go-openssl#13 at this point.