This repository has been archived by the owner on Sep 10, 2022. It is now read-only.
feat: catch panics in the upgrader #107
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier to catch panics.
This is a complex process and panicking here will likely crash the process. This makes for a good "failure" boundary because we'll close the underlying connection if something goes wrong.
Stebalien
force-pushed
the
feat/catch-panic
branch
from
61ed057
to
94067ed
Compare
|
We've decided to handle this at a lower layer. If we do it here, we can't be sure that we're in a consistent state. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a complex process and panicking here will likely crash the process. This makes for a good "failure" boundary because we'll close the underlying connection if something goes wrong.
Part of libp2p/go-libp2p#1389