Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialer.Dial takes remote peerID but does not confirm that it is peer that it connected to #137

Closed
Kubuxu opened this issue Oct 12, 2016 · 3 comments
Closed

Dialer.Dial takes remote peerID but does not confirm that it is peer that it connected to #137

Kubuxu opened this issue Oct 12, 2016 · 3 comments
Labels
exp/expert Having worked on the specific codebase is important help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws)

Comments

@Kubuxu
Copy link
Member

Kubuxu commented Oct 12, 2016 •
edited by whyrusleeping
Loading

It potentially exposes libp2p users to MitM attack if the check isn't done manually after the Dial. We do it in go-libp2p-swarm code but if someone uses Dial directly it might be a problem.

It currently isn't done as secio handshake is done lazily on first usage.
@whyrusleeping whyrusleeping added the status/deferred Conscious decision to pause or backlog label Nov 28, 2016
@daviddias daviddias added kind/bug A bug in existing code (including security flaws) exp/expert Having worked on the specific codebase is important help wanted Seeking public contribution on this issue labels Aug 19, 2017
@jackkleeman
Copy link

I have made a PR for this bug here libp2p/go-libp2p-conn#22

@Stebalien
Copy link
Member

This has been fixed in go-lib2p-conn. The next step is to remove the additional check in go-libp2p-swarm (maybe?).

@jackkleeman jackkleeman mentioned this issue Dec 9, 2017
Closed
@jackkleeman
Copy link

See libp2p/go-libp2p-swarm#48

@ghost ghost removed the status/deferred Conscious decision to pause or backlog label Jul 23, 2018
@MarcoPolo MarcoPolo mentioned this issue Jul 7, 2022
Closed
41 tasks
marten-seemann pushed a commit that referenced this issue Aug 17, 2022
@Stebalien
Merge pull request #137 from libp2p/fix/insecure-transport
695d2b8 
fix: don't drop bytes in the insecure transport
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
exp/expert Having worked on the specific codebase is important help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Stebalien @daviddias @whyrusleeping @Kubuxu @jackkleeman