Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change rcmgr metric namespace to libp2p #2048

Closed
MarcoPolo opened this issue Feb 3, 2023 · 0 comments
Closed

Change rcmgr metric namespace to libp2p #2048

MarcoPolo opened this issue Feb 3, 2023 · 0 comments
Labels
good first issue Good issue for new contributors

Comments

@MarcoPolo
Copy link
Collaborator 

          I think we should do it. Both swarm and eventbus metrics are using the libp2p prefix, would be good to be consistent. Let's do it in a follow-up PR though.

Originally posted by @marten-seemann in #2044 (comment)
@MarcoPolo MarcoPolo added the good first issue Good issue for new contributors label Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good issue for new contributors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MarcoPolo