-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Routed Host Hangs #205
Comments
Could you post a complete repro (or open a PR that reproduces the issue)? |
@Stebalien yeah - made a PR #206 |
It works for me after importing/rewriting the deps using gx (we use gx to deal with dependency versioning): gx-go rewrite
# New deps from your patch.
gx import github.com/libp2p/go-libp2p-kad-dht
gx import github.com/ipfs/go-datastore |
Woot! That worked. Seems like an issue where gx and github has different versions. Thanks @Stebalien. gx looks like a good way to do versioning. Is there a good tutorial for it besides the github repo? I'm interested in trying it out, but the hashes scare me. It would be great to have something like a go-path-to-hash lookup command. |
Sorry for the slow response. I'm not aware of any good tutorials for it and, unfortunately, the hashes are kind of unavoidable due to how go manages dependencies. @whyrusleeping considered using symlinks but go treats packages with different names as different packages even if they have the same code. Note: You don't need to check the hashes into your code (just into packages.json). Instead, you can just call |
correctly export version negotiation failures to Prometheus
This used to work, but something happened recently that it no longer works.
For example, if you take example/echo.go, add
(rhost is github.com/libp2p/go-libp2p/p2p/host/routed)
If we use the KadHost instead of the basicHost for making connections, the connection hangs. Am I missing something here?
The text was updated successfully, but these errors were encountered: