Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log error in accept #2264

Closed
MarcoPolo opened this issue May 1, 2023 · 2 comments · Fixed by #2277
Closed

Log error in accept #2264

MarcoPolo opened this issue May 1, 2023 · 2 comments · Fixed by #2277
Assignees
@MarcoPolo

Comments

@MarcoPolo
Copy link
Collaborator

go-libp2p/p2p/net/swarm/swarm_listen.go

Line 130 in 8313917

return

ignore swarm close errors.
@MarcoPolo MarcoPolo self-assigned this May 1, 2023
nikumbgo12345 pushed a commit to nikumbgo12345/go-libp2p-0305 that referenced this issue May 8, 2023
Log error in accept libp2p#2264
cd06cc9 
added log message in case err when accepting connections
@nikumbgo12345
Copy link

@MarcoPolo i am new to libp2p and trying to contribute , not sure what you mean by the description , have created a PR could you please review and guide

@marten-seemann marten-seemann mentioned this issue May 8, 2023
Closed
@marten-seemann
Copy link
Contributor

@nikumbgo12345 This issue was already assigned to @MarcoPolo. Maybe pick one of the help wanted issues instead?

@MarcoPolo MarcoPolo mentioned this issue May 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MarcoPolo MarcoPolo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

swarm: log unexpected listener errors libp2p/go-libp2p
3 participants
@MarcoPolo @marten-seemann @nikumbgo12345