-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Echo example: yamux potentially broken #258
Comments
Is something actually failing to work? You can get that error if you, e.g., try to write/read (or, in some cases, close) a connection after or while closing a connection (which can happen under perfectly normal conditions). (although, if we're printing that out as an error, we may want to consider reducing the log level). |
This is an internal issue in libp2p, not me writing on a closed connection - I have the same issue with the echo demo, like in #164. Every time you run the dialer it prints this error. |
I can't reproduce it anymore, a few days later. I think there is still some kind of internal bug in the yamux integration that may cause this though. Might be worth looking into it. I'll post again if I see it happen. |
But did it still connect (we conservatively double close connections all over the place)? Actually, that error looks truncated (at the beginning). Is there more? |
Assuming the missing part of that error is
|
You might be right. I haven't seen it again since, but I've been careful to copy/paste the peer ID each time. I'll close this for now, thanks for the help. |
run connection gating tests on both TCP and QUIC
* Add canonical logging for misbehaving peers * Add component and use manet.FromNetAddr * Fix log test
I'm seeing the same error as in #164 in my app -
Use of closed network connection - I think internally the ipv4 connection is closed, but then reused somewhere.
This issue started when I added the yamux transport, like in the Echo demo.
The text was updated successfully, but these errors were encountered: