Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove recommendation about Go module proxy from README #1180

Merged
merged 1 commit into from
Sep 9, 2021

Conversation

marten-seemann
Copy link
Contributor

One can love or hate the Go module proxy, but there's no need to burden go-libp2p users with doing anything out of the ordinary.

@Stebalien
Copy link
Member

That comment came from a time when go get github.com/libp2p/go-libp2p would try to pull in version 6. Is that not the case anymore?

@marten-seemann
Copy link
Contributor Author

Apparently it isn't:

❯ go get github.com/libp2p/go-libp2p
go: downloading github.com/libp2p/go-libp2p v0.15.0-rc.1
go: downloading github.com/libp2p/go-libp2p v0.14.4
go: downloading github.com/libp2p/go-tcp-transport v0.2.4
go: downloading golang.org/x/crypto v0.0.0-20210322153248-0c34fe9e7dc2
go: downloading golang.org/x/sys v0.0.0-20210426080607-c94f62235c83
go get: added github.com/libp2p/go-libp2p v0.14.4

@marten-seemann
Copy link
Contributor Author

The v6.0.23 is listed as incompatible:

❯ go list -m -versions
github.com/libp2p/go-libp2p v0.0.1 v0.0.2 v0.0.3 v0.0.4 v0.0.5 v0.0.6 v0.0.7 v0.0.8 v0.0.9 v0.0.10 v0.0.11 v0.0.12 v0.0.13 v0.0.14 v0.0.15 v0.0.16 v0.0.17 v0.0.18 v0.0.19 v0.0.20 v0.0.21 v0.0.22 v0.0.23 v0.0.24 v0.0.25 v0.0.26 v0.0.27 v0.0.28 v0.0.29 v0.0.30 v0.0.31 v0.0.32 v0.1.0 v0.1.1 v0.1.2 v0.2.0 v0.2.1 v0.3.0 v0.3.1 v0.4.0 v0.4.1 v0.4.2 v0.5.0 v0.5.1 v0.5.2 v0.6.0 v0.6.1 v0.7.0 v0.7.1 v0.7.2 v0.7.3 v0.7.4 v0.8.0 v0.8.1 v0.8.2 v0.8.3 v0.9.0 v0.9.1 v0.9.2 v0.9.3 v0.9.4 v0.9.5 v0.9.6 v0.10.0 v0.10.1 v0.10.2 v0.10.3 v0.11.0 v0.12.0 v0.13.0 v0.14.0 v0.14.1 v0.14.2 v0.14.3 v0.14.4 v0.15.0-rc.1 v6.0.23+incompatible

@Stebalien
Copy link
Member

Nice!

@marten-seemann marten-seemann merged commit d541a8b into master Sep 9, 2021
@marten-seemann marten-seemann deleted the go-module-proxy branch September 17, 2021 16:25
@aschmahmann aschmahmann mentioned this pull request Dec 1, 2021
80 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants