fix flaky BasicHost tests #1202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
approved these changes
Sep 25, 2021
marten-seemann
force-pushed
the
fix-basic-host-test-failures
branch
from
33b67ba
to
bf0203c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1094.
The problem here is that we're dialing a TCP and QUIC connection simultaneously. Occasionally, the timing works out such that the dial limiter kills the QUIC connection right after it has been dialed: https://github.com/libp2p/go-libp2p-swarm/blob/88ef86a16cf0bbc451c3799f63278d345aaf56ea/limiter.go#L228-L234.
From the other host's side (acting as the the QUIC server), this connection looks like a fully functioning connection, and it will happily open a stream on this connection, just to learn a moment later that the connection is getting closed, resulting in the errors we're seeing.
The fix is to have the host that dialed the connect (i.e. the QUIC client) open the stream. This PR therefore swaps the roles of stream initiator / receiver in most tests.