use the resource manager #1275

marten-seemann · 2021-12-30T14:00:59Z

Integrates the ResourceManager in go-libp2p; #1285 and #1289 have been squashed in.

TBD:

integration tests (see Basic resource manager integration tests #1296)

vyzo

We need to do the circuit servers as well, at the stream level -- SetService and reserve the buffers.

p2p/protocol/circuitv2/client/transport.go

vyzo

will open a pr on top for adding rcmgr support in the internal services.

p2p/net/mock/mock_conn.go

p2p/net/mock/mock_peernet.go

p2p/net/mock/mock_stream.go

limits.go

raulk · 2022-01-13T13:23:13Z

p2p/protocol/circuitv1/relay/relay.go

+	// get a scope for memory reservations at service level
+	err := h.Network().ResourceManager().ViewService(ServiceName,
+		func(s network.ServiceScope) error {
+			var err error
+			r.scope, err = s.BeginTransaction()
+			return err
+		})
+	if err != nil {
+		return nil, err
+	}
+


This block looks like it'll become boilerplate. Is there a missing API here?

not really, most services will work at the stream level.

on the same time, it would be very easy to define a utility method to get a txn scope for a service, and it might eliminate some boilerplate.

Where should we put it though?

p2p/protocol/circuitv1/relay/relay.go

p2p/protocol/ping/ping.go

aschmahmann · 2022-01-13T15:42:51Z

defaults.go

+	// Default memory limit: 1/8th of total memory, minimum 128MB, maximum 1GB
+	limiter := rcmgr.NewStaticLimiter(0.125, 128<<20, 1<<30)


The default libp2p node would use at max 1GB of memory? That seems a little low no? Although perhaps if this is just for things like connections and streams we don't have to worry too much.

That's the max for network buffers, which is what we are accounting.
I don't think that's too low, but we can certainly raise it.

aschmahmann · 2022-01-13T15:46:49Z

limits.go

+	if _, ok := limiter.ServiceLimits[identify.ServiceName]; !ok {
+		limiter.ServiceLimits[identify.ServiceName] = limiter.DefaultServiceLimits.
+			WithMemoryLimit(1, 4<<20, 64<<20). // max 64MB service memory
+			WithStreamLimit(128, 128)          // max 128 streams


What's identify going to do here if it needs to be run, but can't (e.g. I want to make more than 128 connections at once and each of those needs to run identify on start).

we have stopped closing the connection if it fails (in master) and we'll also add some code for retrying a few times with exponential backoff.

limits.go

aschmahmann · 2022-01-13T15:56:04Z

limits.go

+		limiter.ServiceLimits[circuitv1.ServiceName] = limiter.DefaultServiceLimits.
+			WithMemoryLimit(1, 4<<20, 64<<20). // max 64MB service memory
+			WithStreamLimit(1024, 1024)        // max 1024 streams
+		limiter.ServicePeerLimits[circuitv1.ServiceName] = peerSvcLimit(128)


Is this for the relayv1 clients? I'd expect servers to have pretty high limits.

Is this a little weird given that if I'm behind a relay it's possible almost all my connections will need to be relayed. Should the connmgr care about this and want to GC so we can make/receive more relayed connections?

Given that we're moving away from relayv1 this might not be so bad, but want to make sure we know + document any gotchas a user might run into

no, this is for the relayv1 server.

aschmahmann · 2022-01-13T15:57:16Z

limits.go

+		limiter.ServiceLimits[circuitv2.ServiceName] = limiter.DefaultServiceLimits.
+			WithMemoryLimit(1, 4<<20, 64<<20). // max 64MB service memory
+			WithStreamLimit(1024, 1024)        // max 1024 streams
+		limiter.ServicePeerLimits[circuitv2.ServiceName] = peerSvcLimit(128)


Is this the client or server for relayv2? Should they be treated separately?

this is the server, the client we don't limit other than the default protocol limits.

and yeah, they are separate and should be treated separately as one is for our own functionality while the other is a service.

p2p/protocol/circuitv2/relay/relay.go

p2p/protocol/ping/ping.go

…lt one

vyzo

ship it!

marten-seemann requested a review from vyzo December 30, 2021 14:00

marten-seemann force-pushed the rcmgr branch from bce30b2 to e12c2ad Compare December 30, 2021 14:03

vyzo reviewed Dec 30, 2021

View reviewed changes

p2p/protocol/circuitv2/client/transport.go Outdated Show resolved Hide resolved

marten-seemann mentioned this pull request Jan 1, 2022

go-libp2p v0.18.0 #1267

Closed

69 tasks

marten-seemann force-pushed the rcmgr branch 2 times, most recently from e8adcae to 5c45c11 Compare January 6, 2022 10:46

vyzo reviewed Jan 7, 2022

View reviewed changes

p2p/net/mock/mock_conn.go Outdated Show resolved Hide resolved

p2p/net/mock/mock_peernet.go Outdated Show resolved Hide resolved

p2p/net/mock/mock_stream.go Outdated Show resolved Hide resolved

marten-seemann force-pushed the rcmgr branch 2 times, most recently from 461485c to 809248a Compare January 8, 2022 17:07

vyzo force-pushed the rcmgr branch from 809248a to 1c531f9 Compare January 10, 2022 07:39

vyzo marked this pull request as ready for review January 10, 2022 12:22

vyzo mentioned this pull request Jan 11, 2022

Basic resource manager integration tests #1296

Merged

raulk reviewed Jan 13, 2022

View reviewed changes

aschmahmann reviewed Jan 13, 2022

View reviewed changes

marten-seemann force-pushed the rcmgr branch 2 times, most recently from 68d94fd to fbab5f7 Compare January 14, 2022 12:48

marten-seemann and others added 8 commits January 18, 2022 12:25

make go-libp2p build when using the resource manager dependencies

4268804

add a ResourceManager option

5f9c407

use the resource manager in libp2p bundled services, initialize defau…

df2301b

…lt one

adjust circuit svc peer limits

ee32902

document default service limits

b9d7b8f

decouple service from peer service limit setting for defaults

1e3bfce

refactor default limit setting, also set protocol limits

3a508fb

adjust circuit protocol limits to give some room for the client

33e8768

marten-seemann force-pushed the rcmgr branch from 696eeb5 to 33e8768 Compare January 18, 2022 08:30

marten-seemann requested a review from vyzo January 18, 2022 08:31

vyzo approved these changes Jan 18, 2022

View reviewed changes

marten-seemann merged commit 15d7dfb into master Jan 18, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

use the resource manager #1275

use the resource manager #1275

marten-seemann commented Dec 30, 2021 •

edited

Loading

vyzo left a comment

vyzo left a comment

raulk Jan 13, 2022

vyzo Jan 13, 2022

vyzo Jan 13, 2022

aschmahmann Jan 13, 2022

vyzo Jan 14, 2022

aschmahmann Jan 13, 2022

vyzo Jan 14, 2022 •

edited

Loading

aschmahmann Jan 13, 2022

vyzo Jan 14, 2022

aschmahmann Jan 13, 2022

vyzo Jan 14, 2022

vyzo Jan 14, 2022

vyzo left a comment

		// Default memory limit: 1/8th of total memory, minimum 128MB, maximum 1GB
		limiter := rcmgr.NewStaticLimiter(0.125, 128<<20, 1<<30)

use the resource manager #1275

use the resource manager #1275

Conversation

marten-seemann commented Dec 30, 2021 • edited Loading

vyzo left a comment

Choose a reason for hiding this comment

vyzo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vyzo Jan 14, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vyzo left a comment

Choose a reason for hiding this comment

marten-seemann commented Dec 30, 2021 •

edited

Loading

vyzo Jan 14, 2022 •

edited

Loading