Close resource manager when host closes #1343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a host is closed, it should close its resource manager. Otherwise, goroutines are leaked. Generally this is not a problem when a host exists for the life of a program, but can be a problem if hosts are created and closed.
willscott
approved these changes
Feb 22, 2022
vyzo
requested changes
Feb 22, 2022
|
whoops, sorry for the fast approval, i mistakenly thought this PR was up a level in application logic |
|
no problem, we do want to close the default instantiation to avoid the
goroutine leak. If you can rework this to track that case, it would be
great.
Otherwise we'll sort it out with marten.
…On Tue, Feb 22, 2022, 20:00 Will ***@***.***> wrote:
whoops, sorry for the fast approval, i mistakenly thought this PR was up a
level in application logic
—
Reply to this email directly, view it on GitHub
<#1343 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAI4SQQW3GXQRDG23NLADTU4PFLTANCNFSM5PCBLRIA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
@gammazero Are you planning to fix this PR? |
|
@marten-seemann I will fix it unless you plan to do so this week. Would you prefer an additional option to tell |
|
I'm going to merge this PR. In fact, we have the same problem with the connection manager, and we also close it when the host closes. |
gammazero
added a commit
to ipni/storetheindex
that referenced
this pull request
Jan 18, 2023
It is not necessary to explicitly close a libp2p host's resource manager. The problem was fixed in this PR: libp2p/go-libp2p#1343
gammazero
added a commit
to ipni/storetheindex
that referenced
this pull request
Jan 18, 2023
* Remove code to resolve address before gostream.Dial This code is not needed as the problem was fixed by this PR: libp2p/go-libp2p#1342 * No longer necessary to explicitly close resource manager It is not necessary to explicitly close a libp2p host's resource manager. The problem was fixed in this PR: libp2p/go-libp2p#1343
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a host is closed, it should close its resource manager. Otherwise, goroutines are leaked.
Generally this is not a problem when a host exists for the life of a program, but can be a problem if hosts are created and closed.