feat: catch panics in identify #1376
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That way, we'll unlock even on panic. We're consuming the remote "peer record" so we might as well be safe.
| if err := s.Scope().SetService(ServiceName); err != nil { | ||
| log.Warnf("error attaching stream to identify service: %s", err) | ||
| s.Reset() |
There was a problem hiding this comment.
You're creating a new err here that shadows the err return value, don't you?
There was a problem hiding this comment.
err will be shadowed inside this condition, but the err in the "defer" will still refer to the named return value.
|
2022-09-16 conversation: we need to evaluate if this is the right place to do this or determine if our panic handlers in serialization functions are sufficient. |
|
Closing since we've done a major refactor of Identify. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We haven't seen any panics in identify, but I'm going through and adding panic handlers to libp2p handlers because the benefits often outweigh the risk:
Part of #1389