autonat: fix flaky TestAutoNATPrivate #1581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
approved these changes
Jun 1, 2022
p2p/host/autonat/autonat_test.go
Outdated
| @@ -121,8 +122,8 @@ func TestAutoNATPrivate(t *testing.T) { | |||
| connect(t, hs, hc) | |||
| require.Eventually(t, | |||
| func() bool { return an.Status() == network.ReachabilityPrivate }, | |||
| 2*time.Second, | |||
| 25*time.Millisecond, | |||
| testutils.ScaleDuration(2*time.Second), | |||
There was a problem hiding this comment.
Any idea why this takes so long? I would've expected 2s to be a long timeout already.
There was a problem hiding this comment.
I know this doesn't answer your real question (why does this take so long to get to that status). But on my laptop this takes 1 second.
=== RUN TestAutoNATPrivate
Took: 1.028655875s to see NAT status as private
--- PASS: TestAutoNATPrivate (1.03s)
So it makes sense that CI would fail here.
There was a problem hiding this comment.
I think it's this second:
go-libp2p/p2p/host/autonat/autonat.go
Lines 256 to 262 in e732bda
Seems like 20s is way too much on CI. Maybe we can just set to 3s?
There was a problem hiding this comment.
It's the upper limit, but sure updated :)
MarcoPolo
changed the base branch from
marco/TestSignedPeerRecordWithNoListenAddrs
to
master
marten-seemann
approved these changes
Jun 2, 2022
MarcoPolo
added a commit
that referenced
this pull request
Jun 24, 2022
* Use expectEvent and scale duration for CI * Use 3 seconds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1566 by scaling duration 3/2x. Waits on a channel.