move go-libp2p-circuit here #1626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. it's not REALAY 2. srcaddr/dstaddr not meaningful for STATUS
so we hand-craft a compatible delimited reader which doesn't.
so that it works for both active and passive connections.
…things per @Stebalien's review comments.
connection might have to resolve through the DHT, so it can take a while.
simplify generation of reservations
fix race condition in TestActiveRelay
remove deprecated types
* base limits on reservations issued * switch default reservation limits per peer and per IP * don't export the constructor for relay.constraints * panic when reading from crypto/rand fails * optimize IP-based reservation lookup * use lists instead of maps to save reservations * save expiry timestamp in reservations * use slices instead of linked lists for reservations * remove unused rand in constraints
implement circuit v2
This code is being moved to go-libp2p.
remove the circuit v2 code
chore: update go-libp2p-core, go-libp2p-swarm
add a Close method, remove the context from the constructor
use the transport.Upgrader interface
use the resource manager
…nal/circuitv1-deprecated
MarcoPolo
approved these changes
Jul 1, 2022
vyzo
approved these changes
Jul 1, 2022
marten-seemann
force-pushed
the
merge-circuit-v1
branch
from
e972f68 to
217fa83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go-libp2p-circuit has been deprecated for a long time, but we're still using it in our circuit v2 compatibility tests.
With the repo consolidation in v0.20 go-libp2p-circuit would now depend on go-libp2p, creating a circular dependency between the two repo (NOT between the packages, so the Go compiler is fine with it).
Assuming that we want to keep the compatibility test, merging -circuit here seems like the least bad thing to do. We're moving it to an
internaldirectory, so that no user can import it.