Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update libp2p to v0.21 in examples #1674

Merged
merged 1 commit into from
Aug 13, 2022
Merged

chore: update libp2p to v0.21 in examples #1674

merged 1 commit into from
Aug 13, 2022

Conversation

Stebalien
Copy link
Member

No description provided.

@Stebalien
Copy link
Member Author

Hm. Looks like we need a DHT update.

@marten-seemann
Copy link
Contributor

Hm. Looks like we need a DHT update.

libp2p/go-libp2p-kad-dht#785?

@Stebalien Stebalien force-pushed the chore/update-examples branch 4 times, most recently from f9a3e70 to f66ee3f Compare August 12, 2022 17:50
@marten-seemann
Copy link
Contributor

Our first generics error:

# github.com/rivo/uniseg
  Error: /Users/runner/go/pkg/mod/github.com/rivo/uniseg@v0.3.4/properties.go:130:6: missing function body
  Error: /Users/runner/go/pkg/mod/github.com/rivo/uniseg@v0.3.4/properties.go:130:20: syntax error: unexpected [, expecting (
  note: module requires Go 1.18
  Error: Process completed with exit code 2.

How's that possible? kad is tested with Go 1.17 as well.

@marten-seemann
Copy link
Contributor

cc @laurentsenta, since you asked about the Go update

@Stebalien
Copy link
Member Author

That's not kad, that was an other update. I'll go revert it.

@Stebalien
Copy link
Member Author

Ok, now we're down to flakes (TestMaxAge).

marten-seemann
marten-seemann approved these changes Aug 13, 2022
View reviewed changes
Copy link
Contributor

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Stebalien!

@marten-seemann marten-seemann changed the title chore: update libp2p in examples chore: update libp2p to v0.21 in examples Aug 13, 2022
@marten-seemann marten-seemann merged commit f5e7cd1 into master Aug 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marten-seemann marten-seemann marten-seemann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Stebalien @marten-seemann