basic_host: Fix flaky tests #2136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| h1.Start() | ||
| h2.Start() | ||
|
|
||
| // Prevent pushing identify information so this test actually _uses_ the super protocol. | ||
| h1.RemoveStreamHandler(identify.IDPush) |
There was a problem hiding this comment.
Why after the Start? This will cause an Identify Push to be sent.
There was a problem hiding this comment.
Start in identify is what sets the stream handler. Removing the stream handler before start is no-op since it's not even registered.
Identify won't do anything until these nodes are connected.
marten-seemann
approved these changes
Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flaky
TestHostProtoPreknowledgetest.