autonat: don't use autonat for address discovery #2148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if as.confidence > 1 { | ||
| as.confidence-- | ||
| } | ||
| // On local address update, reduce confidence from maximum so that we schedule |
There was a problem hiding this comment.
What is a local address update?
There was a problem hiding this comment.
this is any change in the host address list(host.AllAddrs()). I used the phrase from the event EvtLocalAddressesUpdated.
I didn't change this logic much since it was not related to this PR, but the correct thing to do here would be to only reduce confidence if there are any addresses removed from the host address list and our status is public or if there are addresses added and our status is private.
There was a problem hiding this comment.
Yeah, this is fine. Sorry, I messed this up, didn't realize this was literally in the name of the event ;)
marten-seemann
approved these changes
Feb 27, 2023
marten-seemann
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #2102