connmgr: reduce log level for closing connections #2165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd argue that the |
marten-seemann
requested changes
Mar 2, 2023
p2p/net/connmgr/connmgr.go
Outdated
| @@ -173,7 +173,7 @@ func (cm *BasicConnMgr) memoryEmergency() { | |||
|
|
|||
| // Trim connections without paying attention to the silence period. | |||
| for _, c := range cm.getConnsToCloseEmergency(target) { | |||
| log.Infow("low on memory. closing conn", "peer", c.RemotePeer()) | |||
| log.Debugw("low on memory. closing conn", "peer", c.RemotePeer()) | |||
There was a problem hiding this comment.
This definitely shouldn't be hidden as debug. Running low on memory is a pretty serious condition.
| @@ -375,7 +375,7 @@ func (cm *BasicConnMgr) doTrim() { | |||
| func (cm *BasicConnMgr) trim() { | |||
| // do the actual trim. | |||
| for _, c := range cm.getConnsToClose() { | |||
| log.Infow("closing conn", "peer", c.RemotePeer()) | |||
| log.Debugw("closing conn", "peer", c.RemotePeer()) | |||
There was a problem hiding this comment.
Are you sure it's debug? Look at this:
admin@node-01.sm-eu-zur1.spiff.app-test:~ % ls -lh /var/log/docker/spiff-workflow-wakunode/docker.log
-rw-r--r-- 1 syslog syslog 13G Mar 2 13:13 /var/log/docker/spiff-workflow-wakunode/docker.log
admin@node-01.sm-eu-zur1.spiff.app-test:~ % grep 'closing conn' /var/log/docker/spiff-workflow-wakunode/docker.log | wc -l
57729782
This is from 1.5 day of not really that active of a node. If you have a trace level it should be trace.
There was a problem hiding this comment.
I don't think we have a trace log level. Or if we do, we don't use it.
richard-ramos
force-pushed
the
chore/reduce-log-level
branch
from
23d2ca5
to
917cec1
Compare
marten-seemann
approved these changes
Mar 2, 2023
marten-seemann
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the log level for closing connections in connmgr.go from INFO to DEBUG, since as reported in status-im/status-go#3249 these logs add too much noise.