Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

routed host: return connection error instead of routing error #2169

Merged

Conversation

Wondertan
Copy link
Contributor

A peer might not have any connections, and failure to establish the first one will not give a meaningful error, but the failed to find peers: no peers in the table

@marten-seemann marten-seemann changed the title fix(host/routed): return connection error instead of routing routed host: return connection error instead of routing Mar 3, 2023
@marten-seemann marten-seemann changed the title routed host: return connection error instead of routing routed host: return connection error instead of routing error Mar 3, 2023
@marten-seemann marten-seemann merged commit 75efaee into libp2p:master Mar 3, 2023
@Wondertan Wondertan deleted the routed-host/return-conn-err branch March 28, 2023 10:04
@Wondertan
Copy link
Contributor Author

Why wasn't this included in any of the recent releases?

cc @marten-seemann or @MarcoPolo

@MarcoPolo
Copy link
Collaborator

We didn’t explicitly not include this. Generally we try to keep patch releases as small as possible. This will make it into the next minor release.

@Wondertan
Copy link
Contributor Author

@MarcoPolo, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants