Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement webrtc private transport #2177

Closed
wants to merge 227 commits into from
Closed

feat: Implement webrtc private transport #2177

wants to merge 227 commits into from

Commits on Jan 14, 2023

  1. WebRTC transport implementation

    @ckousik
    ckousik committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    ef185f4 View commit details
    Browse the repository at this point in the history

  2. remove bytes.Buffer from datachannel

    @ckousik
    ckousik committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    60d6e9e View commit details
    Browse the repository at this point in the history

  3. fix staticcheck error

    @ckousik
    ckousik committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    d801b5c View commit details
    Browse the repository at this point in the history

  4. fix go fmt

    @ckousik
    ckousik committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    de05336 View commit details
    Browse the repository at this point in the history

  5. remove deadlines and cleanup

    @ckousik
    ckousik committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    96c0899 View commit details
    Browse the repository at this point in the history

  6. simplify read

    @ckousik
    ckousik committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    2464486 View commit details
    Browse the repository at this point in the history

  7. remove comments

    @ckousik
    ckousik committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    6d37367 View commit details
    Browse the repository at this point in the history

  8. rewrite udpmux

    @ckousik
    ckousik committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    433437e View commit details
    Browse the repository at this point in the history

  9. rewrite mux

    @ckousik
    ckousik committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    1c426a2 View commit details
    Browse the repository at this point in the history

  10. remove default multihash

    @ckousik
    ckousik committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    fa8010b View commit details
    Browse the repository at this point in the history

  11. go mod tidy

    @ckousik
    ckousik committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    e8453ad View commit details
    Browse the repository at this point in the history

  12. simplify mux

    @ckousik
    ckousik committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    1701b89 View commit details
    Browse the repository at this point in the history

  13. better deadlines

    @ckousik
    ckousik committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    2e65c7d View commit details
    Browse the repository at this point in the history

  14. minor packetbuffer tests

    @ckousik
    ckousik committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    cea2557 View commit details
    Browse the repository at this point in the history

  15. add unwrap to error type

    @ckousik
    ckousik committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    b1bcf29 View commit details
    Browse the repository at this point in the history

  16. add test for stream closure

    @ckousik
    ckousik committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    6632095 View commit details
    Browse the repository at this point in the history

  17. fix gofmt

    @ckousik
    ckousik committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    b6a33d4 View commit details
    Browse the repository at this point in the history

  18. maxbuffersize fix

    @ckousik
    ckousik committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    48ab83d View commit details
    Browse the repository at this point in the history

  19. fix

    @ckousik
    ckousik committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    c7cc27f View commit details
    Browse the repository at this point in the history

  20. fix read

    @ckousik
    ckousik committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    7cc271d View commit details
    Browse the repository at this point in the history

  21. fix

    @ckousik
    ckousik committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    3aa333d View commit details
    Browse the repository at this point in the history

  22. fix deadlock

    @ckousik
    ckousik committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    e3228aa View commit details
    Browse the repository at this point in the history

  23. added tests

    @ckousik
    ckousik committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    9b51205 View commit details
    Browse the repository at this point in the history

  24. start readloop on first read call

    @ckousik
    ckousik committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    b8bde3f View commit details
    Browse the repository at this point in the history

  25. fix issue

    @ckousik
    ckousik committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    7d48528 View commit details
    Browse the repository at this point in the history

  26. update pion

    @ckousik
    ckousik committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    6081523 View commit details
    Browse the repository at this point in the history

  27. Add comment

    @ckousik
    ckousik committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    5a54581 View commit details
    Browse the repository at this point in the history

  28. remove example

    @ckousik
    ckousik committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    e0c7f25 View commit details
    Browse the repository at this point in the history

  29. gofmt

    @ckousik
    ckousik committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    1bc7c7e View commit details
    Browse the repository at this point in the history

  30. fix test

    @ckousik
    ckousik committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    ee3e979 View commit details
    Browse the repository at this point in the history

  31. address review

    @ckousik
    ckousik committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    2c7578b View commit details
    Browse the repository at this point in the history

  32. add reset to packetqueue

    @ckousik
    ckousik committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    1cfdae8 View commit details
    Browse the repository at this point in the history

  33. more comments

    @ckousik
    ckousik committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    cea86fb View commit details
    Browse the repository at this point in the history

  34. updated webrtc/v3 with setReadDeadline

    @ckousik
    ckousik committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    cfc5b7f View commit details
    Browse the repository at this point in the history

  35. tidy

    @ckousik
    ckousik committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    67683fc View commit details
    Browse the repository at this point in the history

  36. address regression in pion/datachannel

    @ckousik
    ckousik committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    3258011 View commit details
    Browse the repository at this point in the history

  37. force close

    @ckousik
    ckousik committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    aec4b9c View commit details
    Browse the repository at this point in the history

  38. Workaround for datachannel closure 

    If a detached datachannel does not read from the underlying SCTP stream
it may never receive the message that it's remote has closed the stream.
This causes `Read` to block indefinitely, so we use the deadline and a
boolean to force close the Read call and ensure the stream closes.
    @ckousik
    ckousik committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    6329af2 View commit details
    Browse the repository at this point in the history

  39. use buffers from pool for connections

    @ckousik
    ckousik committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    320d047 View commit details
    Browse the repository at this point in the history

  40. add test for stream closure

    @ckousik
    ckousik committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    99c9659 View commit details
    Browse the repository at this point in the history

  41. fix staticcheck error

    @ckousik
    ckousik committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    c7dffaa View commit details
    Browse the repository at this point in the history

  42. address review

    @ckousik
    ckousik committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    c7c1ed0 View commit details
    Browse the repository at this point in the history

  43. stream and connection limiting

    @ckousik
    ckousik committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    8409639 View commit details
    Browse the repository at this point in the history

  44. fix test

    @ckousik
    ckousik committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    0f5a089 View commit details
    Browse the repository at this point in the history

  45. revert to uint32

    @ckousik
    ckousik committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    f90c634 View commit details
    Browse the repository at this point in the history

  46. fixes

    @ckousik
    ckousik committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    fdbb178 View commit details
    Browse the repository at this point in the history

  47. fix receiveMTU

    @ckousik
    ckousik committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    2aa8e2b View commit details
    Browse the repository at this point in the history

  48. update ice version

    @ckousik
    ckousik committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    f59a656 View commit details
    Browse the repository at this point in the history

  49. fix sdp test

    @ckousik
    ckousik committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    cd5e06a View commit details
    Browse the repository at this point in the history

  50. temporarily skip test

    @ckousik
    ckousik committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    75ddec6 View commit details
    Browse the repository at this point in the history

  51. simplify packetqueue

    @ckousik
    ckousik committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    a125544 View commit details
    Browse the repository at this point in the history

  52. fix 1 layer of race conditions

    @ckousik
    ckousik committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    e7bd1e1 View commit details
    Browse the repository at this point in the history

  53. cleanup

    @ckousik
    ckousik committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    99e7c05 View commit details
    Browse the repository at this point in the history

  54. more cleanup

    @ckousik
    ckousik committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    cb74d23 View commit details
    Browse the repository at this point in the history

  55. string benchmarks

    @ckousik
    ckousik committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    ea5987c View commit details
    Browse the repository at this point in the history

  56. grow builder

    @ckousik
    ckousik committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    4af5cd1 View commit details
    Browse the repository at this point in the history

  57. benchmark packetqueue and prevent panic on close

    @ckousik
    ckousik committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    9f760b1 View commit details
    Browse the repository at this point in the history

  58. document lock in packetqueue

    @ckousik
    ckousik committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    9ca5597 View commit details
    Browse the repository at this point in the history

  59. explicit arguments in sdp functions

    @ckousik
    ckousik committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    1bdfea7 View commit details
    Browse the repository at this point in the history

  60. fix default return value of getSupported hashes

    @ckousik
    ckousik committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    00ec1e5 View commit details
    Browse the repository at this point in the history

  61. move to go:generate

    @ckousik
    ckousik committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    91634b6 View commit details
    Browse the repository at this point in the history

  62. polish from load tests

    @ckousik
    ckousik committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    ab21d09 View commit details
    Browse the repository at this point in the history

  63. update go mod

    @ckousik
    ckousik committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    648c02a View commit details
    Browse the repository at this point in the history

  64. update testplans go.mod

    @ckousik
    ckousik committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    33bf244 View commit details
    Browse the repository at this point in the history

  65. update protoc version

    @ckousik
    ckousik committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    115caff View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2023

  1. address remarks of myself of original PR

    glendc committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    f76dfc4 View commit details
    Browse the repository at this point in the history

  2. improve state.go 

    as originally proposed in
'https://github.com/libp2p/go-libp2p/pull/1655/files#r1071283785'
    glendc committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    1be11e9 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2023

  1. Add notes from ckousik to codebase

    glendc committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    b22eed7 View commit details
    Browse the repository at this point in the history

  2. enable transport (webrtc) tests that do work

    glendc committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    5285989 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2023

  1. make DiaerCanCreateStreams test pass again

    glendc committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    c6f290e View commit details
    Browse the repository at this point in the history

  2. further improve state management 

    and switch back to regular mutex for udpMuxStorage until
we have numbers on how well either performs
    glendc committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    6b78134 View commit details
    Browse the repository at this point in the history

  3. minor code changes

    glendc committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    1a9a515 View commit details
    Browse the repository at this point in the history

  4. minor improvements mux.go (webrtc)

    glendc committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    94dbcfa View commit details
    Browse the repository at this point in the history

  5. do not pass string by value in mux.go where not needed

    glendc committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    a5c45d2 View commit details
    Browse the repository at this point in the history

  6. fix bug in webrtc mux: refactor now passes all tests

    glendc committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    50e7394 View commit details
    Browse the repository at this point in the history

  7. fix staticcheck tests

    glendc committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    624a0f5 View commit details
    Browse the repository at this point in the history

  8. add link to go-libp2p webrtc spec

    glendc committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    64b60d9 View commit details
    Browse the repository at this point in the history

  9. add WebRTC benchmarking tool

    glendc committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    464fe64 View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2023

  1. disable std transport test on purpose for WebRTC 

    it won't work due to a mismatch in what WebRTC can handle
and what the transport test expects
    glendc committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    aa80e25 View commit details
    Browse the repository at this point in the history

  2. start cleaning up webrtc bench tool

    glendc committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    8c572bf View commit details
    Browse the repository at this point in the history

  3. implement metrics tracker (stdout or csv file)

    glendc committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    d000415 View commit details
    Browse the repository at this point in the history

  4. fix linting issues

    glendc committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    9b29f54 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2023

  1. improve metrics tracking 

    - include ts
- use total active streams, not last ones
- also keep track when streams go away
    glendc committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    370544d View commit details
    Browse the repository at this point in the history

  2. add report metrics cmd

    glendc committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    787de4e View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2023

  1. add metrics vis and improve reporting + doc

    glendc committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    56e4413 View commit details
    Browse the repository at this point in the history

  2. remove unused pool extra MTU size 

    as noted by ckousik
    glendc committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    a73e4d7 View commit details
    Browse the repository at this point in the history

  3. document how to profile using the webrtc benchmark tool

    glendc committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    f0356a2 View commit details
    Browse the repository at this point in the history

  4. remove TODO from README of webrtc benchmark

    glendc committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    91d834c View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2023

  1. add Benchmark chapter to WebRTC BM tool README

    glendc committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    10e00ba View commit details
    Browse the repository at this point in the history

  2. use correct scripts for benchmark example cmds

    glendc committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    b3acaa0 View commit details
    Browse the repository at this point in the history

  3. also keep tracks of bytes read/written in metrics for WebRTC

    glendc committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    a75e179 View commit details
    Browse the repository at this point in the history

  4. bugfix metrics collection client/server (webrtc)

    glendc committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    705706d View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2023

  1. move visualise to sep dir & support autogen csv metrics file name

    glendc committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    dffbd1c View commit details
    Browse the repository at this point in the history

  2. make visualise script work with multiple files (e.g. server/client)

    glendc committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    bc3b211 View commit details
    Browse the repository at this point in the history

  3. include results (CSV) in benchmark results

    glendc committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    8e52e36 View commit details
    Browse the repository at this point in the history

  4. continue to improve benchmark code

    glendc committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    ac077ce View commit details
    Browse the repository at this point in the history

  5. define transports for benchmark explicitly

    glendc committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    0aa7c6b View commit details
    Browse the repository at this point in the history

  6. add fork reference and update listrenPort

    glendc committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    a0c421f View commit details
    Browse the repository at this point in the history

  7. give back 9999 listen port for benchmark tool as def

    glendc committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    4bd827e View commit details
    Browse the repository at this point in the history

  8. divide CPU % by total cpu cores as to get actual %

    glendc committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    624fc78 View commit details
    Browse the repository at this point in the history

  9. remove dead code (client sdp (2))

    glendc committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    9801531 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2023

  1. support merge on single datapoint for webrtc bench

    glendc committed Jan 28, 2023
    Configuration menu
    Copy the full SHA
    62d698f View commit details
    Browse the repository at this point in the history

  2. refactor metrics script and easily print metric stats as MD table 

    further prep for mass bench run
    glendc committed Jan 28, 2023
    Configuration menu
    Copy the full SHA
    a636032 View commit details
    Browse the repository at this point in the history

  3. remove flag dep from lib runner code

    glendc committed Jan 28, 2023
    Configuration menu
    Copy the full SHA
    1d087c9 View commit details
    Browse the repository at this point in the history

  4. fix linter error

    glendc committed Jan 28, 2023
    Configuration menu
    Copy the full SHA
    3c47f7f View commit details
    Browse the repository at this point in the history

  5. add multirunner tool 

    acts as an orchestrator to more easily run the benchmarks
of the documented scenarios
    glendc committed Jan 28, 2023
    Configuration menu
    Copy the full SHA
    062ebc4 View commit details
    Browse the repository at this point in the history

  6. fix runner: now it works :)

    glendc committed Jan 28, 2023
    Configuration menu
    Copy the full SHA
    cf1c6d8 View commit details
    Browse the repository at this point in the history

  7. update benchmark README: simplify cmds now that we have multinner

    glendc committed Jan 28, 2023
    Configuration menu
    Copy the full SHA
    0fc8cf1 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2023

  1. add benchmark files for webrtc and other transports

    glendc committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    3b3b459 View commit details
    Browse the repository at this point in the history

  2. add more graphs to webrtc README benchmark

    glendc committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    fd7bd8f View commit details
    Browse the repository at this point in the history

  3. fix cases for ws png image link in README

    glendc committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    7912d1f View commit details
    Browse the repository at this point in the history

  4. fix dial cmd multirunner for s2 benchmark

    glendc committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    74cdf10 View commit details
    Browse the repository at this point in the history

  5. go mod tidy

    glendc committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    01dae45 View commit details
    Browse the repository at this point in the history

  6. fix tests CI (multirunner flag parse)

    glendc committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    bbcf8d2 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2023

  1. sync SDP messages with Rust version

    glendc committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    8423c52 View commit details
    Browse the repository at this point in the history

  2. make sdp tests pass again (webrtc)

    glendc committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    e4fc599 View commit details
    Browse the repository at this point in the history

  3. add benchmark results comparing quic to webrtc

    glendc committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    bb8aea4 View commit details
    Browse the repository at this point in the history

  4. support bench multirunner to use only a single transport 

    useful when iterating on a single transport
    glendc committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    26bf7ec View commit details
    Browse the repository at this point in the history

  5. update benchmark results to latest webrtc

    glendc committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    2f4f0c6 View commit details
    Browse the repository at this point in the history

  6. upgrade pion dependencies (webrtc)

    glendc committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    e177fc6 View commit details
    Browse the repository at this point in the history

  7. remove webrtc options for dialing that are incompatible 

    these caused it not to be able to connect to the Rust implementation.
Removing makes it work with both a Go listener, but also a Rust listener
    glendc committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    4bb2012 View commit details
    Browse the repository at this point in the history

  8. fix README cmds

    glendc committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    36a4208 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2023

  1. fix open TODOs that can be fixed

    glendc committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    453d6dd View commit details
    Browse the repository at this point in the history

  2. minor improvement, mostly styling

    glendc committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    bb35fbe View commit details
    Browse the repository at this point in the history

  3. remove outdated code and remove unneeded string alloc

    glendc committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    135af07 View commit details
    Browse the repository at this point in the history

  4. optimise hex conversions further and string allocs

    glendc committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    56cc945 View commit details
    Browse the repository at this point in the history

  5. remove duplicate hex code

    glendc committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    a0a43ec View commit details
    Browse the repository at this point in the history

  6. avoid even more string allocs

    glendc committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    ce7e970 View commit details
    Browse the repository at this point in the history

  7. go mod tidy

    glendc committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    4ed95a0 View commit details
    Browse the repository at this point in the history

  8. update benchmarks based on latest PR branch status

    glendc committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    e33a05e View commit details
    Browse the repository at this point in the history

  9. avoid more string allocs

    glendc committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    61177e9 View commit details
    Browse the repository at this point in the history

  10. add TODO to flaky test 

    probably the reason the CI tests fail for some platforms usually
    glendc committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    13ffbee View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2023

  1. fix ch leak and minor ux improvements

    glendc committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    3567409 View commit details
    Browse the repository at this point in the history

  2. remove TODO regarding flaky test, might have been fixed already

    glendc committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    ca29407 View commit details
    Browse the repository at this point in the history

  3. log dial error when it occurs in prod

    glendc committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    161d12e View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2023

  1. Merge remote-tracking branch 'origin/master' into feat/webrtc

    glendc committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    4b79b20 View commit details
    Browse the repository at this point in the history

  2. go mod tidy

    glendc committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    b79924e View commit details
    Browse the repository at this point in the history

  3. minor improvements and more docs

    glendc committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    c51ef68 View commit details
    Browse the repository at this point in the history

  4. go mod tidy testplans

    glendc committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    7d63c7b View commit details
    Browse the repository at this point in the history

  5. increase dial timeout for MaxInFlightRequests test 

    seems 5s is a bit too tight for our CI machines
    glendc committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    a5aa714 View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2023

  1. resolve data race in muxed_connection.go 

    simplifying by not closing chn,
given the resource does get cleaned up, and we
do not expect the ch to be closed from a busines Pov
it will be okay like this
    glendc committed Feb 4, 2023
    Configuration menu
    Copy the full SHA
    ff689f2 View commit details
    Browse the repository at this point in the history

  2. code cleanup

    glendc committed Feb 4, 2023
    Configuration menu
    Copy the full SHA
    64154c8 View commit details
    Browse the repository at this point in the history

  3. clean up code

    glendc committed Feb 4, 2023
    Configuration menu
    Copy the full SHA
    eea5874 View commit details
    Browse the repository at this point in the history

  4. simplify code regarding maxInFlight

    glendc committed Feb 4, 2023
    Configuration menu
    Copy the full SHA
    a1cb991 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2023

  1. refactor stream.go (webrtc) 

    - remove usage of mutexes
- switch to channels and background workers instead
    glendc committed Feb 5, 2023
    Configuration menu
    Copy the full SHA
    748519f View commit details
    Browse the repository at this point in the history

  2. skip broken tests (due to refactor)

    glendc committed Feb 5, 2023
    Configuration menu
    Copy the full SHA
    9a65869 View commit details
    Browse the repository at this point in the history

  3. ensure response writer can handle if responseCh is blocked :)

    glendc committed Feb 5, 2023
    Configuration menu
    Copy the full SHA
    0613582 View commit details
    Browse the repository at this point in the history

  4. swap done check

    glendc committed Feb 5, 2023
    Configuration menu
    Copy the full SHA
    ae5c5ec View commit details
    Browse the repository at this point in the history

  5. remove unused varf

    glendc committed Feb 5, 2023
    Configuration menu
    Copy the full SHA
    1fda8b0 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2023

  1. split up stream code (webrtc)

    glendc committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    e42c314 View commit details
    Browse the repository at this point in the history

  2. move util webrtc code to internal package (soc)

    glendc committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    0633a90 View commit details
    Browse the repository at this point in the history

  3. move Signal also to its own internal package for WebRTC

    glendc committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    898f668 View commit details
    Browse the repository at this point in the history

  4. add forgotten pointer for ref function

    glendc committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    70f33af View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2023

  1. move state back into webrtc stream

    glendc committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    7c246a7 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2023

  1. more refactor: deadline fix

    glendc committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    ca1a374 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2023

  1. simplify/refactor stream code 

    and enable tests which now pass once again
    glendc committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    5be3cdc View commit details
    Browse the repository at this point in the history

  2. remove unused props/types of stream

    glendc committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    264ce0c View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/master' into feat/webrtc

    glendc committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    ade34df View commit details
    Browse the repository at this point in the history

  4. fix max in flight conn test

    glendc committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    0febdbd View commit details
    Browse the repository at this point in the history

  5. sync code with original ckousik code

    glendc committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    b350d71 View commit details
    Browse the repository at this point in the history

  6. re-add closeErr hack defined by ckousik (just to be sure)

    glendc committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    c06e1a3 View commit details
    Browse the repository at this point in the history

  7. fix tests: all should pass now

    glendc committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    dd1f3a8 View commit details
    Browse the repository at this point in the history

  8. update benchmarks for webrtc for latest code

    glendc committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    3437272 View commit details
    Browse the repository at this point in the history

  9. update S2 benchmarks (FC)

    glendc committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    e2b107c View commit details
    Browse the repository at this point in the history

  10. simplify WebRTC reader code (fix deadline bug)

    glendc committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    3df32db View commit details
    Browse the repository at this point in the history

  11. accept webrtc accept queue better 

    - accepting conns is expensive
- this makes it that we have a robust limit on how manny conns can be open
    glendc committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    e9a0d49 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2023

  1. switch establishing conns (webrtc) to worker pool

    glendc committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    9545df6 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2023

  1. remove benchmark to sep repo 

    https://github.com/little-bear-labs/libp2p-go-webrtc-benchmarks
    glendc committed Feb 12, 2023
    Configuration menu
    Copy the full SHA
    c201a81 View commit details
    Browse the repository at this point in the history

  2. doc hex interpersed + remove async/mutex

    glendc committed Feb 12, 2023
    Configuration menu
    Copy the full SHA
    cd47d16 View commit details
    Browse the repository at this point in the history

  3. resolve more review comments

    glendc committed Feb 12, 2023
    Configuration menu
    Copy the full SHA
    82be234 View commit details
    Browse the repository at this point in the history

  4. give pckt queue ctx done its own err

    glendc committed Feb 12, 2023
    Configuration menu
    Copy the full SHA
    cbe1061 View commit details
    Browse the repository at this point in the history

  5. resolve more comments from review

    glendc committed Feb 12, 2023
    Configuration menu
    Copy the full SHA
    4f7ecf1 View commit details
    Browse the repository at this point in the history

  6. update link to new benchmark repo

    glendc committed Feb 12, 2023
    Configuration menu
    Copy the full SHA
    09da05e View commit details
    Browse the repository at this point in the history

  7. go mod tidy (remove pidusage dep)

    glendc committed Feb 12, 2023
    Configuration menu
    Copy the full SHA
    fb8837c View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2023

  1. handle more review comments

    glendc committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    3c43902 View commit details
    Browse the repository at this point in the history

  2. fix linter error

    glendc committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    79193f8 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2023

  1. address some more review comments

    glendc committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    dae5b9d View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2023

  1. improve webrtc by resolving more review comments

    glendc committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    7e21fa3 View commit details
    Browse the repository at this point in the history

  2. further clean up code

    glendc committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    957fab9 View commit details
    Browse the repository at this point in the history

  3. remove wg from stream

    glendc committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    9bb2578 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2023

  1. add more comments and resolve MR review

    glendc committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    4a55ff7 View commit details
    Browse the repository at this point in the history

  2. merge stream back into one

    glendc committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    0b5fcc4 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2023

  1. switch to mafmt.UDP to also allow DNS addresses (not just IP)

    glendc committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    62b3b1c View commit details
    Browse the repository at this point in the history

  2. prevent pkt queue alloc when not used (webrtc)

    glendc committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    4981ecb View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2023

  1. remove shorter read in packetsQueue::pop

    glendc committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    2039cfc View commit details
    Browse the repository at this point in the history

  2. bugfix muxed_connection.go

    glendc committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    c771813 View commit details
    Browse the repository at this point in the history

  3. fix dialMatcher selection + test

    glendc committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    40fa481 View commit details
    Browse the repository at this point in the history

  4. skip failing tests to get an idea of what is failing

    glendc committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    f4764d2 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2023

  1. fix broken TestTransportWebRTC_Read test

    glendc committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    8fe8727 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2023

  1. fix last remaining failing unit tests

    glendc committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    fcb4b45 View commit details
    Browse the repository at this point in the history

  2. fix unit test (linux) + linter (check)

    glendc committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    abe126d View commit details
    Browse the repository at this point in the history

  3. fix linter (check): unused var

    glendc committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    bd2903b View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2023

  1. fix conns in flight, this is now properly respecting the max

    glendc committed Feb 26, 2023
    Configuration menu
    Copy the full SHA
    094ed17 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into feat/webrtc

    glendc committed Feb 26, 2023
    Configuration menu
    Copy the full SHA
    d8ab714 View commit details
    Browse the repository at this point in the history

  3. remove dirty err hack that used to be needed for read errs

    glendc committed Feb 26, 2023
    Configuration menu
    Copy the full SHA
    57d3c3d View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2023

  1. apply some feeback alreay

    glendc committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    d322b52 View commit details
    Browse the repository at this point in the history

  2. clean up code further and apply feedback

    glendc committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    c2aa10b View commit details
    Browse the repository at this point in the history

  3. use go-msgio to write prefixe msg on wire

    glendc committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    367bcc4 View commit details
    Browse the repository at this point in the history

  4. add fuzz test for hex interperse util

    glendc committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    4c3f2c2 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2023

  1. correctly check if slice in EncodeInterperseHexToBuilder is empty

    glendc committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    ed64f22 View commit details
    Browse the repository at this point in the history

  2. fix hex webrtc util code based on fuzz tests

    glendc committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    e2ca309 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2023

  1. resolve more review comments

    glendc committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    cf1dff5 View commit details
    Browse the repository at this point in the history

  2. max in flight conns with a single worker 

    apply more feedback
    glendc committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    f20f40f View commit details
    Browse the repository at this point in the history

  3. handle previously ignored errors

    glendc committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    cf6093e View commit details
    Browse the repository at this point in the history

  4. improve testing and code for webrtc

    glendc committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    133e9ae View commit details
    Browse the repository at this point in the history

  5. more hex tests

    glendc committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    4842b38 View commit details
    Browse the repository at this point in the history

  6. move awaitPeerConnectionOpen out internal to avoid needing log there

    glendc committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    bf9e3fc View commit details
    Browse the repository at this point in the history

  7. fix lint checks

    glendc committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    130b2c4 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2023

  1. address more review comments

    glendc committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    6db8135 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into feat/webrtc

    glendc committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    feb2551 View commit details
    Browse the repository at this point in the history

  3. remove priv key from connection (no longer needed)

    glendc committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    db47c11 View commit details
    Browse the repository at this point in the history

  4. address more comments

    glendc committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    4dfc547 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2023

  1. address more comments

    glendc committed Mar 11, 2023
    Configuration menu
    Copy the full SHA
    deb7d7d View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2023

  1. drop custom CondVar sync primitive 

    use a single buffered ch instead
    glendc committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    181fa15 View commit details
    Browse the repository at this point in the history

  2. move GetDataChannel to private function in root webrtc pkg

    glendc committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    6f35a1b View commit details
    Browse the repository at this point in the history

  3. add comment to explain why connection internal setters are required

    glendc committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    1ba7457 View commit details
    Browse the repository at this point in the history

  4. add high level webrtc test

    glendc committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    131c48a View commit details
    Browse the repository at this point in the history

  5. use IncludeLoopbackCandidate(true) for webrtc's pion

    glendc committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    99ba632 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2023

  1. Update p2p/transport/webrtc/stream.go 

    Co-authored-by: Marten Seemann <martenseemann@gmail.com>
    @GlenDC @marten-seemann
    GlenDC and marten-seemann authored Mar 15, 2023
    Configuration menu
    Copy the full SHA
    dfdbb26 View commit details
    Browse the repository at this point in the history

  2. do not make ICE timeouts configurable for WebRTC

    glendc committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    87b988d View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/master' into feat/webrtc

    glendc committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    2b4d03d View commit details
    Browse the repository at this point in the history

  4. fix more comments

    glendc committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    2e6eb77 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2023

  1. feat: Initial webrtc-w3c implementation

    @ckousik
    ckousik committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    9a9b7ea View commit details
    Browse the repository at this point in the history

  2. base test

    @ckousik
    ckousik committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    820c499 View commit details
    Browse the repository at this point in the history

  3. start adding a transport for webrtc w3c

    @ckousik
    ckousik committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    58a5c44 View commit details
    Browse the repository at this point in the history

  4. rename protofile

    @ckousik
    ckousik committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    56119e9 View commit details
    Browse the repository at this point in the history

  5. fix staticcheck issues

    @ckousik
    ckousik committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    3ef0f32 View commit details
    Browse the repository at this point in the history