Add fallback dialer #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were unable to dial on a given transport if there were no listener addresses defined for that. This meant that most people couldnt use utp (as they had no utp listener transport to dial from).
| return fbd.tcpDial(a) | ||
| } | ||
| if mafmt.UTP.Matches(a) { | ||
| } |
There was a problem hiding this comment.
Isn't something missing here? probably tbd.utpDial(a)
There was a problem hiding this comment.
.> don't judge me
|
Apart from that comment, LGTM. |
marten-seemann
pushed a commit
that referenced
this pull request
Apr 19, 2022
marten-seemann
pushed a commit
that referenced
this pull request
Apr 19, 2022
marten-seemann
pushed a commit
that referenced
this pull request
Apr 26, 2022
Consolidate abstractions and core types into go-libp2p-core (#28)
marten-seemann
pushed a commit
that referenced
this pull request
Aug 17, 2022
marten-seemann
added a commit
that referenced
this pull request
Sep 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were unable to dial on a given transport if there were no
listener addresses defined for that. This meant that most people couldnt
use utp (as they had no utp listener transport to dial from).