identify: fix normalization of interface listen addresses #2250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What’s the issue that this PR intends to solve? |
marten-seemann
approved these changes
Apr 12, 2023
p2p/protocol/identify/obsaddr.go
Outdated
Comment on lines
371
to
374
| type connMultiaddrProvider interface { | ||
| RemoteMultiaddr() ma.Multiaddr | ||
| LocalMultiaddr() ma.Multiaddr | ||
| } |
There was a problem hiding this comment.
Reuse this interface?
go-libp2p/core/network/conn.go
Lines 70 to 80 in 952f7cb
marten-seemann
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous fix in #2235 was so close, but didn't catch this bug since ListenAddrs == InterfaceListeneAddrs in the mocknet.