allow tag to be passed into NewMdnsService #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kubuxu
approved these changes
Sep 25, 2017
This was referenced Sep 25, 2017
Closed
whyrusleeping
approved these changes
Sep 29, 2017
|
Hey, thanks for merging. Currently my use of libp2p seems to be governed by the gx version. So I don't actually have access to this change until there's a gx bump. What's your process around that, or perhaps am I doing something wrong on my end in the use of the repo? |
|
Hey @zippy, I can run a gx publish of this for you so you can update it within your package. |
|
Alright, published go-libp2p 5.0.3: https://github.com/libp2p/go-libp2p/blob/master/.gx/lastpubver In your application that is importing go-libp2p via gx, you will need to run |
marten-seemann
pushed a commit
that referenced
this pull request
Apr 21, 2022
* support for forced direct connections.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation uses the constant ServiceTag which is set to an ipfs specific value. As a generalized p2p library this value should be settable by the caller to NewMdnsService.