swarm: implement Happy Eyeballs ranking #2365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukunrt
changed the title
marten-seemann
added
the
status/blocked
marten-seemann
removed
the
status/blocked
sukunrt
force-pushed
the
happy-eyeballs-dialing
branch
from
9bf1c22
to
a276a21
Compare
marten-seemann
approved these changes
Jun 28, 2023
p2p/net/swarm/dial_ranker.go
Outdated
| if isQUICAddr(addrs[0]) && isProtocolAddr(addrs[0], ma.P_IP6) { | ||
| for i := 1; i < len(addrs); i++ { | ||
| if isQUICAddr(addrs[i]) && isProtocolAddr(addrs[i], ma.P_IP4) { | ||
| addrs[i], addrs[1] = addrs[1], addrs[i] |
There was a problem hiding this comment.
Is swapping the right thing to do here, or should the address be inserted at position 1, shifting all other addresses?
There was a problem hiding this comment.
There's no impact because we have three tiers:
IPv6 dialed first, IPv4 dialed second, rest of the addresses.
I'll change it to shifting though because that seems more correct in case we eventually want to dial only a single address at a time.
sukunrt
force-pushed
the
happy-eyeballs-dialing
branch
from
a276a21
to
fcdb696
Compare
marten-seemann
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #2320
Ignores #2349 We can take that up after this.