swarm: move all connection post processing to worker loop #2462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukunrt
force-pushed
the
sukun/happy-eyeballs-tcp-3
branch
from
6b39900
to
b1c30cf
Compare
| // dialAddr is the actual dial for an addr, indirectly invoked through the limiter | ||
| func (s *Swarm) dialAddr(ctx context.Context, p peer.ID, addr ma.Multiaddr) (transport.CapableConn, error) { | ||
| func (s *Swarm) dialAddr(ctx context.Context, p peer.ID, addr ma.Multiaddr, resCh chan dialResult) { |
There was a problem hiding this comment.
Suggested change
| func (s *Swarm) dialAddr(ctx context.Context, p peer.ID, addr ma.Multiaddr, resCh chan dialResult) { | |
| func (s *Swarm) dialAddr(ctx context.Context, p peer.ID, addr ma.Multiaddr, resCh chan<- dialResult) { |
p2p/net/swarm/dial_worker.go
Outdated
| connected bool | ||
| // dq is used to pace dials to different addresses of the peer | ||
| dq *dialQueue | ||
| // dialsInFlight are the addresses with dials pending completion. |
There was a problem hiding this comment.
It's not addresses, it's just a counter?
|
Closing in favour of #2573 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for #2394