quic: update quic-go to v0.37.5 #2488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
MarcoPolo
force-pushed
the
marco/update-quic-go
branch
from
bf17c93
to
2364c02
Compare
MarcoPolo
changed the title
Revert this commit when we release a new go-libp2p version compatible with Go 1.21
MarcoPolo
force-pushed
the
marco/update-quic-go
branch
from
2364c02
to
9e1f3fc
Compare
|
Failing interop tests against zig-libp2p pretty reliably. Debugging this now. |
|
Interop issue will be fixed in the next version of quic-go |
This was referenced Aug 17, 2023
marten-seemann
changed the title
marten-seemann
approved these changes
Aug 17, 2023
marten-seemann
force-pushed
the
marco/update-quic-go
branch
from
a69915d
to
9121d01
Compare
|
Wrong merge target. Will recreate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch is targetting on #2487. Updates quic-go and our usage of it. I'd recommend reviewing this PR commit by commit because the hack to avoid running examples in Go 1.21 is noisy.
The workaround for examples is only temporary. The issue is that the examples use a released version of go-libp2p, but no released version supports Go 1.21 yet. This ignores Go 1.21 in the examples. This commit is designed to be reverted when we release the next version of go-libp2p.
Also note that this works around this issue: quic-go/quic-go#4029. A later version of quic-go will fix this.