libp2phttp: don't strip / suffix when mounting handler
#2552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukunrt
commented
Sep 3, 2023
marten-seemann
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to serve
/a/bwhen we mount ahttp.ServeMuxhandler for/bon a libp2phost at path/a.Currently this is a 404 as
/a/bwill reach the handler for/bwith the urlbas we strip/a/.The paths on a
ServeMuxhave to begin with/ascleanPathhere will add the prefix/and then the comparison here will redirect to the cleaned path. This redirect will cause a 404. See the added test and linked issue for details.There is an annoying case though,
closes: #2545