Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: basichost: Add backoff for updating local IP addresses on error #2999

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

MarcoPolo
Copy link
Collaborator

closes #2996

@MarcoPolo MarcoPolo requested a review from sukunrt October 8, 2024 20:49
@MarcoPolo MarcoPolo changed the title Add backoff for updating local IP addresses on error fix: Add backoff for updating local IP addresses on error Oct 8, 2024
@MarcoPolo MarcoPolo changed the title fix: Add backoff for updating local IP addresses on error fix: basichost: Add backoff for updating local IP addresses on error Oct 8, 2024
@sukunrt
Copy link
Member

sukunrt commented Oct 9, 2024

Do we need this interface selection logic at all? Shouldn't we advertise all interface addresses when we are listening on 0.0.0.0 or ::?

@MarcoPolo
Copy link
Collaborator Author

Maybe.

  1. This isn't related to listen address.
  2. Really the whole basichost's Addrs logic needs a overhaul.
  3. This is semantically the same, but nicer in the case of errors.

@sukunrt
Copy link
Member

sukunrt commented Oct 10, 2024

Isn't the whole point of this method to get our interface addresses so that we can accurately report our listen addresses and not 0.0.0.0?

@MarcoPolo MarcoPolo merged commit c79cf36 into master Oct 16, 2024
13 checks passed
@MarcoPolo MarcoPolo mentioned this pull request Oct 17, 2024
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants