swarm_test: support more transports for GenSwarm #3130
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukunrt
force-pushed
the
sukun/swarm-test-1
branch
from
214f779 to
cc8e5fa
Compare
This adds support for `/webtransport` andn `/webrtc-direct` to GenSwarm. Ideally, we should rewrite this to have the same semantics, opt into transports not opt out, as `libp2p.New`. But I need webtransport and webrtc support to write address inference tests for #3075 Depending on how disruptive this is to users, we can decide on whether to merge or drop this.
sukunrt
force-pushed
the
sukun/swarm-test-1
branch
from
cc8e5fa to
29f2fa4
Compare
MarcoPolo
reviewed
Jan 8, 2025
| @@ -191,6 +209,75 @@ func GenSwarm(t testing.TB, opts ...Option) *swarm.Swarm { | |||
| if err := s.Listen(ma.StringCast("/ip4/127.0.0.1/udp/0/quic-v1")); err != nil { | |||
| t.Fatal(err) | |||
| } | |||
| for _, a := range s.ListenAddresses() { | |||
| if _, err := a.ValueForProtocol(ma.P_QUIC_V1); err == nil { | |||
| quicListenAddr = a | |||
There was a problem hiding this comment.
It's not obvious to me why you want to share this address with all the other transports. Can you explain? Also what happens if ListenAddresses contains a different address for WebTransport?
There was a problem hiding this comment.
You're right. We should replicate how the basic host works which just listens on port 0.
There was a problem hiding this comment.
The intention was to be maximially similar to how people use this in production. That can be handled separately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for
/webtransportand/webrtc-directto GenSwarm.Ideally, we should rewrite this to have the same semantics, opt into transports not opt out, as
libp2p.New. But I need webtransport and webrtc support to write address inference tests for #3075Depending on how disruptive this is to users, we can decide on whether to merge or drop this.