Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ran gosimple (github.com/dominikh/go-simple) on go-libp2p #77

Merged
merged 1 commit into from
Jul 27, 2016
Merged

Ran gosimple (github.com/dominikh/go-simple) on go-libp2p #77

merged 1 commit into from
Jul 27, 2016

Conversation

John-Steidley
Copy link
Contributor

No description provided.

@John-Steidley John-Steidley changed the title gosimple Ran gosimple (github.com/dominikh/go-simple) on go-libp2p Jul 27, 2016
@@ -86,7 +86,7 @@ func (d *Dialer) Dial(ctx context.Context, raddr ma.Multiaddr, remote peer.ID) (
return
}

if d.PrivateKey == nil || EncryptConnections == false {
if d.PrivateKey == nil || !EncryptConnections {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only open question in my mind, why style do you prefer?

@whyrusleeping
Copy link
Contributor

LGTM! Thanks!

@whyrusleeping whyrusleeping merged commit 5b9cd67 into libp2p:master Jul 27, 2016
@John-Steidley John-Steidley deleted the gosimple branch July 27, 2016 09:40
marten-seemann pushed a commit that referenced this pull request Apr 21, 2022
marten-seemann pushed a commit that referenced this pull request Apr 22, 2022
use log.Warn instead of log.Warning
marten-seemann added a commit that referenced this pull request Apr 26, 2022
fix typo in error message
marten-seemann pushed a commit that referenced this pull request Jul 1, 2022
Tag the hop relay when creating stop streams
marten-seemann pushed a commit that referenced this pull request Aug 17, 2022
fix(plaintext): regenerate protobuf code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants