Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid a close deadlock in the natmanager #971

Merged
merged 1 commit into from
Jun 23, 2020
Merged

Commits on Jun 22, 2020

  1. fix: avoid a close deadlock in the natmanager

    Before, we would:
    
    1. Receive a "listen close" event from an event handler, after the teardown started.
    2. Try to add a child process to handle the event. This would block because we
    were in the teardown.
    3. In the teardown, try to unregister the event handler and deadlock
    
    I've now:
    
    * Removed the teardown.
    * Switched to a single event loop.
    
    Ideally, we'd remove goprocess entirely. But we'd need to refactor natmgr.
    
    fixes #933
    Stebalien committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    72770db View commit details
    Browse the repository at this point in the history