add a MemoryManager interface to control memory allocations #96
Conversation
multiplex.go
Outdated
| @@ -171,7 +199,10 @@ func (mp *Multiplex) CloseChan() <-chan struct{} { | |||
| } | |||
|
|
|||
| func (mp *Multiplex) sendMsg(timeout, cancel <-chan struct{}, header uint64, data []byte) error { | |||
| buf := pool.Get(len(data) + 20) | |||
| buf, err := mp.pool.Get(len(data) + 20) | |||
There was a problem hiding this comment.
The problem here is that returning an error might not lead to a connection failure. For example, in NewStream it will just cause us to return an error and a nil stream, but not do anything with the stream that was already created.
This is not something that this PR introduced though... Still wondering if we maybe should always kill the connection when an allocation fails.
There was a problem hiding this comment.
thats very problematic, there is no way to signal failure.
What will happen if we do nothing?
Do we leak or simply have a broken stream?
If we leak, then yes we got to kill the conn. Otherwise we can get away without doinig anything (probably), although it would be nice to be able to return an error to the other side.
Either way, up to you.
|
|
||
| func (mp *Multiplex) getBuffer(length int) ([]byte, error) { | ||
| if err := mp.memoryManager.ReserveMemory(length, 128); err != nil { | ||
| mp.closeNoWait() |
No description provided.