sync: update CI config files

[web3-bot]

Syncing to commit protocol/.github@68389df.

[marten-seemann]

I hadn't seen that @Stebalien had already rebased this.

[Stebalien]

Ah, and the 32bit tests are failing because we don't have CGO.

[Stebalien]

And the windows tests are failing because we don't have openssl.

[marten-seemann]

And the windows tests are failing because we don't have openssl.

This is the second time in a single day that the feature request came up to disable Windows tests (the other one is: filecoin-shipyard/js-lotus-client-schema#16 (comment)).

[Stebalien]

Well... I'd rather install openssl, if we can.

[marten-seemann]

Ah, I thought that's not possible. We could use a custom setup step for that.

[Stebalien]

Yep. Working on it.

[Stebalien]

Ok, so the pc (pkg-config) file still isn't getting installed. I think we need to move to msys2 for windows (https://github.com/msys2/setup-msys2). Really, we can probably switch to this by default to make our lives easier.

[marten-seemann]

Do we need to do this for all shells that run on Windows, or is it sufficient to do that in the repo-specific setup step?

[Stebalien]

Do we need to do this for all shells that run on Windows, or is it sufficient to do that in the repo-specific setup step?

It should be possible to do this in the setup only but:

1. It's a bit annoying because if conditionals don't work inside "composite" actions. So we'd need to use the "default" bash, check if we're running on windows, then launch a msys bash shell script.
2. I'm not sure what environment variables we need to setup if we can't just run msys2 everywhere. I think it's just PATH and then something for pkg-config? But I'm not sure.

[aschmahmann]

Update: GH Actions now support if in composites which should make our lives easier here.

[marten-seemann]

We have a PR that changes the shell to msys2 on Windows: protocol/.github#221. It would be really valuable to try it out in this repo. @galargh, is that a task you could take? To do so, you'd create a new branch which manually updates the workflow files to the PR linked above. We could then see if the tests actually pass. That would allow us to merge protocol/.github#221 with confidence that it actually solves the problem.

[galargh]

@galargh, is that a task you could take?

Sure! I will check it out and report back here and under protocol/.github#221

[galargh]

I made sure we're set up correctly for CGO in #20. Note: if there is a unified CI deploy before we merge https://github.com/protocol/.github/tree/next into master then it will try to overwrite the changes made here to go-test.yml. That PR will fail however because it won't pass the tests. So it can create a bit of noise but it will auto-resolve once the next big release of unified CI is out. Just wanted to point it out.