Skip to content
This repository has been archived by the owner on May 26, 2022. It is now read-only.

remove incorrect statement about dns addresses in README #100

Merged
merged 1 commit into from
Sep 25, 2021

Conversation

marten-seemann
Copy link
Contributor

We even have a test case that we cannot dial dns addresses:

func TestTcpTransportCantDialDNS(t *testing.T) {
for i := 0; i < 2; i++ {
dnsa, err := ma.NewMultiaddr("/dns4/example.com/tcp/1234")
if err != nil {
t.Fatal(err)
}
_, sm := makeInsecureMuxer(t)
tpt := NewTCPTransport(&tptu.Upgrader{
Secure: sm,
Muxer: new(mplex.Transport),
})
if tpt.CanDial(dnsa) {
t.Fatal("shouldn't be able to dial dns")
}
envReuseportVal = false
}
envReuseportVal = true
}

Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm. Yeah, we handle resolution at a higher layer.

@marten-seemann marten-seemann merged commit 87d46c6 into master Sep 25, 2021
@aschmahmann aschmahmann mentioned this pull request Dec 1, 2021
80 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants