Skip to content
This repository has been archived by the owner on May 26, 2022. It is now read-only.

use the ResourceManager #110

Merged
merged 1 commit into from
Jan 18, 2022
Merged

use the ResourceManager #110

merged 1 commit into from
Jan 18, 2022

Conversation

marten-seemann
Copy link
Contributor

@marten-seemann marten-seemann requested a review from vyzo December 22, 2021 11:12
vyzo
vyzo reviewed Dec 22, 2021
View reviewed changes
tcp.go Outdated
return nil, err
}
if err := connScope.SetPeer(p); err != nil {
return nil, err
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need a Done if it fails I think -- should we do that automagically?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah we definitely need a Done, we own it at this point.

vyzo
vyzo reviewed Dec 30, 2021
View reviewed changes
Copy link

@vyzo vyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in the failure path!

marten-seemann
marten-seemann commented Dec 31, 2021
View reviewed changes
tcp.go Outdated Show resolved Hide resolved
vyzo
vyzo reviewed Dec 31, 2021
View reviewed changes
Copy link

@vyzo vyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marten-seemann marten-seemann mentioned this pull request Jan 1, 2022
Closed
69 tasks
@marten-seemann marten-seemann force-pushed the rcmgr branch 8 times, most recently from 7ee275c to 5b0f844 Compare January 8, 2022 17:00
@marten-seemann marten-seemann force-pushed the rcmgr branch 2 times, most recently from 729a43e to e760df1 Compare January 14, 2022 11:55
@marten-seemann marten-seemann marked this pull request as ready for review January 18, 2022 05:56
@marten-seemann marten-seemann merged commit 70d7181 into master Jan 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vyzo vyzo vyzo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marten-seemann @vyzo