Skip to content
This repository has been archived by the owner on May 26, 2022. It is now read-only.

refactor for transport interface changes #23

Merged
merged 2 commits into from
Jun 6, 2018
Merged

refactor for transport interface changes #23

merged 2 commits into from
Jun 6, 2018

Conversation

Stebalien
Copy link
Member

Also, refactor out reuseport logic into a separate package.

New packages:

  • go-reuseport-transport - provides a reuseport "transport" that handles all the annoying reuseport logic (e.g., figuring out which port to dial from when listening on multiple ports/addresses).
  • go-libp2p-transport-upgrader - provides helpers to upgrade basic transports to fully-featured transports (encryption, etc.)

DO NOT MERGE (yet)
Part of: libp2p/go-libp2p#297

@ghost ghost assigned Stebalien Mar 10, 2018
@ghost ghost added the status/in-progress In progress label Mar 10, 2018
@Stebalien Stebalien mentioned this pull request Mar 10, 2018
Closed
72 tasks
Stebalien
Stebalien commented Mar 12, 2018
View reviewed changes
reuseport.go
@@ -35,31 +33,3 @@ func init() {
func ReuseportIsAvailable() bool {
return envReuseportVal && reuseport.Available()
}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to the reuseport transport.

reuseport_test.go
@@ -1,48 +0,0 @@
package tcp
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to the reuseport transport.

@Stebalien Stebalien requested a review from whyrusleeping March 12, 2018 23:54
@Stebalien
Copy link
Member Author

Reviewed by @whyrusleeping.

@Stebalien Stebalien force-pushed the feat/refactor branch 2 times, most recently from 824e05f to 761dc94 Compare March 29, 2018 08:18
@Stebalien Stebalien force-pushed the feat/refactor branch 2 times, most recently from 3c88e8d to 182045e Compare June 5, 2018 01:32
Stebalien added 2 commits June 4, 2018 19:02
@Stebalien
refactor for transport interface changes
e095ac8 
Also, refactor out reuseport logic into a separate package.
@Stebalien
gx publish 2.0.0
6f74c62
@Stebalien Stebalien merged commit 753b87d into master Jun 6, 2018
@ghost ghost removed the status/in-progress In progress label Jun 6, 2018
@Stebalien Stebalien deleted the feat/refactor branch June 6, 2018 07:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@whyrusleeping whyrusleeping Awaiting requested review from whyrusleeping

Assignees

@Stebalien Stebalien

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Stebalien