This repository was archived by the owner on Mar 11, 2020. It is now read-only.
update the dial interface to cope with new pull additions #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 tasks
| @@ -96,12 +94,7 @@ This method dials a transport to the Peer listening on `multiaddr`. | |||
|
|
|||
| `callback` should follow the `function (err, conn)` signature. | |||
|
|
|||
| `conn` is the same `conn` that gets returned by call, which should follow [`interface-connection`](https://github.com/diasdavid/interface-connection). This `conn` object can emit 3 extra events: | |||
There was a problem hiding this comment.
The callback now has the signature of only function (err) not with the conn inside
There was a problem hiding this comment.
We don't want to leave the conn inside too?
There was a problem hiding this comment.
It's not at this point at least
There was a problem hiding this comment.
I would like to keep it there too, it is convenient when used with waterfall flows, fine :)
| @@ -15,9 +30,12 @@ | |||
| "url": "https://github.com/diasdavid/interface-transport/issues" | |||
| }, | |||
| "homepage": "https://github.com/diasdavid/interface-transport", | |||
| "devDependencies": {}, | |||
| "devDependencies": { | |||
| "aegir": "^7.0.1" | |||
|
I see you added tests 👍 now it needs a rebase :) |
dignifiedquire
force-pushed
the
feat/update-pull
branch
from
72f1241 to
aff8834
Compare
daviddias
force-pushed
the
feat/update-pull
branch
from
99abe2c to
9e489b2
Compare
daviddias
force-pushed
the
feat/update-pull
branch
from
9e489b2 to
d50224d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.