This repository has been archived by the owner on Oct 30, 2023. It is now read-only.
fix: send user agent header with libp2p version #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `AgentVersion` metadata is set by the identify service. If it's present, send it as the user agent header with all requests. N.b. this is currently broken in Chromium as it doesn't allow overriding the user agent in fetch requests event though the spec says it should.
|
Marking this as a draft because it needs Chrome to support the fetch spec properly before it'll work. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
AgentVersionmetadata is set by the identify service.If it's present, send it as the user agent header with all requests.
N.b. this is currently broken in Chromium as it doesn't allow overriding the user agent in fetch requests event though the spec says it should.
Fixes #10