#92: use callback in start from js-libp2p

[generalpiston]

No description provided.

[vasco-santos]

Thanks for your PR @generalpiston

Asked you for a simple change

[vasco-santos]

also @generalpiston Can you please rebase this PR with master?

[generalpiston]

Done

[vasco-santos]

LGTM! Thanks for the PR @generalpiston

[alanshaw]

@vasco-santos this repo has already been converted to async/await. There should be no callbacks here. If there's bugfixes that are needed in the callback version then they need to be backported to a v0.9.x branch.

[vasco-santos]

you are right @alanshaw !

I completely missed that this module was already converted. I will revert this commit!

@generalpiston libp2p-bootstrap@0.9.x already includes the callback in start. We are currently migrating all the modules to async/await, as while this is a WIP some latest versions might not be in use. In this context, libp2p is still using 0.9.7, which uses the callback implementation. Once some other dependencies get converted, and libp2p will upgrade those dependencies and will be refactored accordingly!

[generalpiston]

@vasco-santos that makes perfect sense. Should we update the package.json peerDependencies to use a newer version of js-libp2p? Or add a note to the README?

[vasco-santos]

I created a PR on js-libp2p to warn people about this.

Thanks @generalpiston