Skip to content
This repository has been archived by the owner on Jun 27, 2023. It is now read-only.

fix: replace node buffers with uint8arrays #109

Merged
merged 2 commits into from
Aug 11, 2020

Conversation

achingbrain
Copy link
Member

Replaces all use of node Buffers with Uint8Arrays

BREAKING CHANGES:

  • The .data property of received pubsub messages was a Buffer, now it is a Uint8Array
  • All deps of this module use Uint8Arrays

Replaces all use of node Buffers with Uint8Arrays

BREAKING CHANGES:

- The `.data` property of received pubsub messages was a Buffer,
  now it is a Uint8Array
- All deps of this module use Uint8Arrays
Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking a look into the README ❤️
This looks good to me! I will just add a commit to bump libp2p-pubsub before merging in

@vasco-santos vasco-santos merged commit 9f3498d into master Aug 11, 2020
@vasco-santos vasco-santos deleted the fix/replace-node-buffers-with-uint8arrays branch August 11, 2020 10:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants