chore: update deps #114
chore: update deps #114
Conversation
vasco-santos
force-pushed
the
chore/update-deps-and-remove-protons
branch
2 times, most recently
from
6c12a36 to
e497bc1
Compare
vasco-santos
force-pushed
the
chore/update-deps-and-remove-protons
branch
from
e497bc1 to
8e5c200
Compare
vasco-santos
force-pushed
the
chore/update-deps-and-remove-protons
branch
from
af1955f to
a474cf4
Compare
| @@ -0,0 +1 @@ | |||
| export const { Buffer } = require('buffer') | |||
There was a problem hiding this comment.
probably should include the "buffer" dependency too I guess
package.json
Outdated
| @@ -9,11 +9,11 @@ | |||
| "test": "aegir test", | |||
| "test:node": "aegir test -t node", | |||
| "test:browser": "aegir test -t browser", | |||
| "build": "aegir build", | |||
| "build": "aegir build --no-types", | |||
There was a problem hiding this comment.
we want types, but we are not adding types to all libp2p modules for the time being: libp2p/js-libp2p#659
We are focusing first on guarantee that libp2p provides types for the user surface area, which is essentially libp2p + libp2p-interfaces. Slowly, we should roll up the remaining modules, as some libp2p modules (including this) also need libp2p and libp2p-interfaces to have types, as libp2p is provided to the modules.
There was a problem hiding this comment.
Either way, once I release interfaces I can add types here as this should be super fast
.github/workflows/main.yml
Outdated
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - run: npm install | ||
| - run: npx aegir test -t browser -t webworker --bail -- --browsers FirefoxHeadless |
There was a problem hiding this comment.
| - run: npx aegir test -t browser -t webworker --bail -- --browsers FirefoxHeadless | |
| - run: npx aegir test -t browser -t webworker --bail -- --browser firefox |
Otherwise this will run on chromium
.github/workflows/main.yml
Outdated
| with: | ||
| node-version: ${{ matrix.node }} | ||
| - run: npm install | ||
| - run: npx nyc --reporter=lcov aegir test -t node -- --bail |
There was a problem hiding this comment.
| - run: npx nyc --reporter=lcov aegir test -t node -- --bail | |
| - run: npx aegir test -t node --cov --bail |
No need for nyc
.github/workflows/main.yml
Outdated
| - uses: actions/checkout@v2 | ||
| - run: npm install | ||
| - run: npx aegir lint | ||
| - run: npx aegir dep-check -- -i wrtc -i electron-webrtc |
There was a problem hiding this comment.
| - run: npx aegir dep-check -- -i wrtc -i electron-webrtc | |
| - run: npx aegir dep-check |
No need to ignore wrtc and electron-webrtc
vasco-santos
force-pushed
the
chore/update-deps-and-remove-protons
branch
from
a5e5191 to
9461f61
Compare
Updating all the dependencies and removing protons in favour of protobufjs for smaller bundles and avoiding bundle problems with web-encoding. This follows the work that is in progress in libp2p to use protobufjs everywhere.
Needs: