Skip to content
This repository has been archived by the owner on Jun 27, 2023. It is now read-only.

chore: remove peer deps #115

Merged
merged 2 commits into from
Apr 15, 2021
Merged

chore: remove peer deps #115

merged 2 commits into from
Apr 15, 2021

Conversation

achingbrain
Copy link
Member

We added peer deps to signal to the user that they should add the modules they depend on as deps of their project.

Starting with npm7 all peer deps get installed automatically which defeats the purpose of our use of peer deps, so let's remove them.

We added peer deps to signal to the user that they should add the modules they depend on as deps of their project.

Starting with npm7 all peer deps get installed automatically which defeats the purpose of our use of peer deps, so let's remove them.
@achingbrain
Copy link
Member Author

It also means you can't test rcs of libp2p without getting this error:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: js-ipfs@1.0.0
npm ERR! Found: libp2p@0.31.0-rc.0
npm ERR! node_modules/libp2p
npm ERR!   libp2p@"0.31.0-rc.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer libp2p@"^0.30.0" from libp2p-floodsub@0.25.0
npm ERR! node_modules/libp2p-floodsub
npm ERR!   libp2p-floodsub@"^0.25.0" from the root project

@vasco-santos vasco-santos force-pushed the chore/remove-peer-deps branch from d4908c6 to 2af52c2 Compare April 15, 2021 14:33
@vasco-santos
Copy link
Member

We need to get #113 in and change we handle this. I will try to prioritize that work.

@vasco-santos vasco-santos merged commit 9f916db into master Apr 15, 2021
@vasco-santos vasco-santos deleted the chore/remove-peer-deps branch April 15, 2021 15:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants