This repository has been archived by the owner on Jun 26, 2023. It is now read-only.
feat: update pubsub getMsgId return type to Uint8Array #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for updating this @wemeetagain |
BREAKING CHANGE: new getMsgId return type is not backwards compatible with prior `string` return type.
wemeetagain
force-pushed
the
feat/pubsub-msgid-uint8array
branch
from
693a272 to
a16de1e
Compare
vasco-santos
approved these changes
Oct 5, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See libp2p/specs#285
BREAKING CHANGE:
new getMsgId return type is not backwards compatible with prior
stringreturn type.