Skip to content
This repository was archived by the owner on Jun 26, 2023. It is now read-only.

Conversation

@wemeetagain
Copy link
Member

Unfortunately, #66, as merged, had several errors with the typescript types:

  • the globalSignaturePolicy type was set as SignaturePolicy, rather than string
    • the idea is that SignaturePolicy is the "type" of the enum, which is how this would be described if this was written in typescript. Unfortunately, this type was not exported so there was a type mismatch.
  • the checked-in typescript declaration files were not updated

This PR rectifies both issues

Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vasco-santos vasco-santos merged commit 269a6f5 into libp2p:master Nov 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants