chore: apply suggestions from code review

Co-Authored-By: Jacob Heun <jacobheun@gmail.com>
libp2p · Nov 19, 2019 · ba96e12 · ba96e12
1 parent aa29260
commit ba96e12
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 12 deletions.
diff --git a/src/content-routing/index.js b/src/content-routing/index.js
@@ -71,7 +71,7 @@ module.exports = (dht) => {
      * @param {number} options.maxNumProviders - maximum number of providers to find
      * @returns {Promise<PeerInfo>}
      */
-    async findProviders (key, options = {}) { // eslint-disable-line require-await
+    async findProviders (key, options = {}) {
       const providerTimeout = options.timeout || c.minute
       const n = options.maxNumProviders || c.K
 

diff --git a/src/index.js b/src/index.js
@@ -303,7 +303,7 @@ class KadDHT extends EventEmitter {
    * the message.
    *
    * @param {Message} msg
-   * @returns {Promose<Array<PeerInfo>>}
+   * @returns {Promise<Array<PeerInfo>>}
    * @private
    */
   async _nearestPeersToQuery (msg) {
@@ -459,7 +459,7 @@ class KadDHT extends EventEmitter {
    *
    * @param {PeerId} peer
    * @param {Buffer} key
-   * @returns {Promise<{Record, Array<PeerInfo}>} // TODO: define obj
+   * @returns {Promise<{Record, Array<PeerInfo}>}
    * @private
    */
 

diff --git a/test/kad-dht.spec.js b/test/kad-dht.spec.js
@@ -411,7 +411,6 @@ describe('KadDHT', () => {
       const tdht = new TestDHT()
       const dhts = await tdht.spawn(4)
 
-      // const addrs = dhts.map((d) => d.peerInfo.multiaddrs.toArray()[0])
       const ids = dhts.map((d) => d.peerInfo.id)
       const idsB58 = ids.map(id => id.toB58String())
       sinon.spy(dhts[3].network, 'sendMessage')
@@ -448,12 +447,6 @@ describe('KadDHT', () => {
 
         expect(provs).to.have.length(1)
         expect(provs[0].id.id).to.be.eql(ids[3].id)
-        // TODO: /ipfs => /p2p
-        // expect(
-        //   provs[0].multiaddrs.toArray()[0].toString()
-        // ).to.equal(
-        //   addrs[3].toString()
-        // )
       })
 
       return tdht.teardown()

diff --git a/test/providers.spec.js b/test/providers.spec.js
@@ -108,8 +108,6 @@ describe('Providers', () => {
 
   // slooow so only run when you need to
   it.skip('many', async function () {
-    this.timeout(100 * 1000)
-
     const p = path.join(
       os.tmpdir(), (Math.random() * 100).toString()
     )