Skip to content
This repository has been archived by the owner on Jul 21, 2023. It is now read-only.

fix: add buffer #185

Merged
merged 1 commit into from
Apr 27, 2020
Merged

fix: add buffer #185

merged 1 commit into from
Apr 27, 2020

Conversation

hugomrdias
Copy link
Member

No description provided.

@hugomrdias hugomrdias requested a review from vasco-santos April 27, 2020 09:26
Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! PR Branch is failing though, can you have a look?

@hugomrdias
Copy link
Member Author

seems unrelated and PR run is green dunno whats happening

https://travis-ci.com/github/libp2p/js-libp2p-kad-dht/jobs/323739748#L323

@vasco-santos
Copy link
Member

I tried restarting the branch CI but it kept failing. So, I tried locally to run the tests, but I am getting the same result as in CI, while master branch is working for me locally.

It is strange that the PR is getting green

@vasco-santos vasco-santos merged commit a28d279 into master Apr 27, 2020
@vasco-santos vasco-santos deleted the fix/add-buffer branch April 27, 2020 15:44
vasco-santos pushed a commit that referenced this pull request Apr 27, 2020
@vasco-santos
Copy link
Member

Released this commit into 0.18.7 as latest and will also release this as 0.19.2as a beta release

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants