This repository has been archived by the owner on Jul 21, 2023. It is now read-only.
fix: replace node buffers with uint8arrays #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces all use of node Buffers with Uint8Arrays BREAKING CHANGES: - Where node Buffers were returned, now Uint8Arrays are
Gozala
approved these changes
Aug 7, 2020
| @@ -329,7 +329,7 @@ describe('Query', () => { | |||
|
|
|||
| it('disjoint path values', async () => { | |||
| const peerId = dht.peerId | |||
| const values = ['v0', 'v1'].map(Buffer.from) | |||
| const values = ['v0', 'v1'].map((str) => uint8ArrayFromString(str)) | |||
There was a problem hiding this comment.
looks like you could pass uint8ArrayFromString directly to map, here and in two more cases below.
There was a problem hiding this comment.
The signature for the function passed to Array.map is function callback( currentValue[, index[, array]]), so if you just pass uint8ArrayFromString it tries to interpret the index as a text encoding and fails.
jacobheun
approved these changes
Aug 10, 2020
64 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces all use of node Buffers with Uint8Arrays
Depends on:
BREAKING CHANGES: