This repository has been archived by the owner on Jul 21, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 60
fix: refactor query logic #237
Merged
Merged
Changes from 18 commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
12d39e0
fix: refactor query logic
achingbrain 8c99da8
chore: remove libp2p from component types
achingbrain 5f953d3
chore: query manager tests passing
achingbrain 36aae55
chore: kad-dht tests passing
achingbrain d965111
fix: couple of tests left
achingbrain f4fca0b
chore: tests passing
achingbrain 05b7005
chore: swap travis for gh actions
achingbrain 27707e2
chore: test on node
achingbrain 416e19d
chore: ignore coverage dir
achingbrain 12204ac
chore: update parallel
achingbrain a234676
chore: make timeouts optional
achingbrain cc1e3d4
chore: speed up tests
achingbrain 8e5fe2b
chore: allow sub-queries to time out without aborting the whole query
achingbrain 6e287c8
chore: restore prepare script, get datastore from libp2p
achingbrain 546db47
fix: bubbled up query errors should be non-fatal
achingbrain 09eb418
chore: temp fix for fix node 14
achingbrain e351e02
feat: query self occasionally
achingbrain 0d63aee
chore: linting
achingbrain 43be700
feat: add query event handlers
achingbrain 1c8a125
feat: events all the way down
achingbrain 287a77a
chore: tests passing for events
achingbrain a29959a
chore: tests passing again
achingbrain c61ca6c
chore: linting
achingbrain ac53b24
chore: listen to connection events
achingbrain 93e2dd1
chore: linting
achingbrain 1d5f2f5
chore: do not expose dht messages
achingbrain ac8698b
chore: fields will always be set
achingbrain 4af423b
chore: avoid leaking libp2p-record in types as it depends on crypto
achingbrain fffed89
fix: split DHTs into lan and wan
achingbrain 2e96752
chore: rename as events
achingbrain 36e198e
chore: let caller throw and only continue query if xor is closer
achingbrain 6bdf4b4
chore: fix flaky test
achingbrain 04e7aca
chore: add missing dep
achingbrain e8f882f
chore: better logging
achingbrain dc47b5c
chore: update implementation summary
achingbrain 1cfea97
chore: address review comments
achingbrain 1ead080
chore: slow ci is slow
achingbrain File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
name: ci | ||
on: | ||
push: | ||
branches: | ||
- master | ||
pull_request: | ||
branches: | ||
- master | ||
|
||
jobs: | ||
check: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- run: npm install | ||
- run: npx aegir lint | ||
- uses: gozala/typescript-error-reporter-action@v1.0.8 | ||
- run: npx aegir build | ||
- run: npx aegir dep-check | ||
- uses: ipfs/aegir/actions/bundle-size@master | ||
name: size | ||
with: | ||
github_token: ${{ secrets.GITHUB_TOKEN }} | ||
test-node: | ||
needs: check | ||
runs-on: ${{ matrix.os }} | ||
strategy: | ||
matrix: | ||
os: [windows-latest, ubuntu-latest, macos-latest] | ||
node: [14, 16] | ||
fail-fast: true | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- uses: actions/setup-node@v1 | ||
with: | ||
node-version: ${{ matrix.node }} | ||
- run: npm install | ||
- run: npx nyc --reporter=lcov aegir test -t node -- --bail | ||
- uses: codecov/codecov-action@v1 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -41,3 +41,4 @@ test/test-data/go-ipfs-repo/LOG.old | |
# while testing npm5 | ||
package-lock.json | ||
yarn.lock | ||
.nyc_output |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems too frequent, can this be configured? Looks like spec default is 5mins https://github.com/libp2p/specs/tree/master/kad-dht#bootstrap-process.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's exposed as the
querySelfInterval
factory function option. Will increase the default to 5 mins