This repository has been archived by the owner on Jul 21, 2023. It is now read-only.
chore: upgrade deps #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGES: - All deps of this module now use Uint8Arrays instead of node Buffers
64 tasks
jacobheun
reviewed
Aug 11, 2020
src/compat/responder.js
Outdated
| @@ -4,6 +4,7 @@ const OS = require('os') | |||
| const MDNS = require('multicast-dns') | |||
| const log = require('debug')('libp2p:mdns:compat:responder') | |||
| const { SERVICE_TAG_LOCAL } = require('./constants') | |||
| const { Buffer } = require('buffer') | |||
There was a problem hiding this comment.
Is there a reason for including buffer? mdns only works in Node, so Buffer should always be available.
jacobheun
reviewed
Aug 11, 2020
| @@ -35,18 +35,17 @@ | |||
| "homepage": "https://github.com/libp2p/js-libp2p-mdns", | |||
| "devDependencies": { | |||
| "aegir": "^25.0.0", | |||
| "chai": "^4.2.0", | |||
There was a problem hiding this comment.
Dep check is failing with chai removed, there must be some remaining usages of it.
jacobheun
approved these changes
Aug 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGES: