This repository has been archived by the owner on Jul 21, 2023. It is now read-only.
chore: update deps #119
Merged
chore: update deps #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull in latest bl, errcode, etc
achingbrain
commented
Apr 16, 2021
| msgs.push(msg) | ||
|
|
||
| if (i++ >= maxMsgs) { |
There was a problem hiding this comment.
This was a bit weird - iso-random-stream behaves a bit differently to random-bytes and was causing the initiator to abort immediately before the final message was echoed back from the receiver. I think random-bytes causes execution to pause until the next tick of the event loop instead or something along those lines, so I moved the abort to after the echoed message collection.
77 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull in latest bl, errcode, etc